-
Notifications
You must be signed in to change notification settings - Fork 4
Build images as multi-arch (amd64 + arm64) manifest lists. #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
7a7a174
cbca49a
06dc625
b111102
4b036f7
13c7da8
8b8114e
e7c167f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ jobs: | |
| contents: read | ||
| packages: write | ||
| steps: | ||
| - name: Prune untagged images | ||
| - name: Prune stale PR test image tags | ||
| uses: vlaurin/action-ghcr-prune@0cf7d39f88546edd31965acba78cdcb0be14d641 #v0.6.0 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
@@ -21,4 +21,8 @@ jobs: | |
| keep-younger-than: 30 # days | ||
| prune-tags-regexes: | | ||
| ^[a-z0-9]+_merge- | ||
| prune-untagged: true | ||
| # IMPORTANT: do NOT enable prune-untagged. With multi-arch manifest | ||
| # lists, each per-arch child manifest appears "untagged" in GHCR even | ||
| # though it is referenced by a tagged manifest list. Pruning untagged | ||
| # images would dereference the manifest lists and break pulls. | ||
| prune-untagged: false | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Disabling The trade-off: cancelled/failed runs (and Worth a follow-up issue: enumerate child digests of stale |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| .idea | ||
| .DS_Store | ||
| digests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious do you know why we need an Oracle token now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh Claude says it's needed for
buildx🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need this to get the latest Oracle JDK 8