Allow ignoring the agent version when checking for trace stats computation support#11064
Draft
Allow ignoring the agent version when checking for trace stats computation support#11064
Conversation
886907e to
e9b55d0
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053941
Total [baseline] (10.96 s) : 0, 10959851
Agent [candidate] (1.059 s) : 0, 1058662
Total [candidate] (11.096 s) : 0, 11096341
section appsec
Agent [baseline] (1.253 s) : 0, 1253049
Total [baseline] (11.096 s) : 0, 11096288
Agent [candidate] (1.243 s) : 0, 1243163
Total [candidate] (11.197 s) : 0, 11197405
section iast
Agent [baseline] (1.225 s) : 0, 1225355
Total [baseline] (11.212 s) : 0, 11211829
Agent [candidate] (1.219 s) : 0, 1218915
Total [candidate] (11.276 s) : 0, 11276496
section profiling
Agent [baseline] (1.184 s) : 0, 1183571
Total [baseline] (11.015 s) : 0, 11014806
Agent [candidate] (1.186 s) : 0, 1185543
Total [candidate] (11.0 s) : 0, 10999510
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.231 ms) : 0, 1231
BytebuddyAgent [baseline] (630.849 ms) : 0, 630849
BytebuddyAgent [candidate] (633.548 ms) : 0, 633548
AgentMeter [baseline] (29.286 ms) : 0, 29286
AgentMeter [candidate] (29.501 ms) : 0, 29501
GlobalTracer [baseline] (247.603 ms) : 0, 247603
GlobalTracer [candidate] (248.719 ms) : 0, 248719
AppSec [baseline] (31.952 ms) : 0, 31952
AppSec [candidate] (31.873 ms) : 0, 31873
Debugger [baseline] (59.995 ms) : 0, 59995
Debugger [candidate] (60.182 ms) : 0, 60182
Remote Config [baseline] (609.538 µs) : 0, 610
Remote Config [candidate] (612.142 µs) : 0, 612
Telemetry [baseline] (8.13 ms) : 0, 8130
Telemetry [candidate] (8.128 ms) : 0, 8128
Flare Poller [baseline] (8.295 ms) : 0, 8295
Flare Poller [candidate] (8.807 ms) : 0, 8807
section appsec
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (665.359 ms) : 0, 665359
BytebuddyAgent [candidate] (659.312 ms) : 0, 659312
AgentMeter [baseline] (12.039 ms) : 0, 12039
AgentMeter [candidate] (11.984 ms) : 0, 11984
GlobalTracer [baseline] (249.692 ms) : 0, 249692
GlobalTracer [candidate] (247.929 ms) : 0, 247929
IAST [baseline] (24.702 ms) : 0, 24702
IAST [candidate] (24.484 ms) : 0, 24484
AppSec [baseline] (184.452 ms) : 0, 184452
AppSec [candidate] (183.785 ms) : 0, 183785
Debugger [baseline] (66.376 ms) : 0, 66376
Debugger [candidate] (65.664 ms) : 0, 65664
Remote Config [baseline] (620.596 µs) : 0, 621
Remote Config [candidate] (592.586 µs) : 0, 593
Telemetry [baseline] (8.554 ms) : 0, 8554
Telemetry [candidate] (8.483 ms) : 0, 8483
Flare Poller [baseline] (3.599 ms) : 0, 3599
Flare Poller [candidate] (3.519 ms) : 0, 3519
section iast
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (802.772 ms) : 0, 802772
BytebuddyAgent [candidate] (798.373 ms) : 0, 798373
AgentMeter [baseline] (11.414 ms) : 0, 11414
AgentMeter [candidate] (11.319 ms) : 0, 11319
GlobalTracer [baseline] (239.057 ms) : 0, 239057
GlobalTracer [candidate] (237.671 ms) : 0, 237671
IAST [baseline] (25.726 ms) : 0, 25726
IAST [candidate] (25.683 ms) : 0, 25683
AppSec [baseline] (31.727 ms) : 0, 31727
AppSec [candidate] (32.542 ms) : 0, 32542
Debugger [baseline] (61.935 ms) : 0, 61935
Debugger [candidate] (59.177 ms) : 0, 59177
Remote Config [baseline] (1.134 ms) : 0, 1134
Remote Config [candidate] (522.413 µs) : 0, 522
Telemetry [baseline] (10.663 ms) : 0, 10663
Telemetry [candidate] (12.662 ms) : 0, 12662
Flare Poller [baseline] (3.527 ms) : 0, 3527
Flare Poller [candidate] (3.625 ms) : 0, 3625
section profiling
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (690.936 ms) : 0, 690936
BytebuddyAgent [candidate] (690.586 ms) : 0, 690586
AgentMeter [baseline] (9.11 ms) : 0, 9110
AgentMeter [candidate] (9.159 ms) : 0, 9159
GlobalTracer [baseline] (206.768 ms) : 0, 206768
GlobalTracer [candidate] (208.193 ms) : 0, 208193
AppSec [baseline] (32.518 ms) : 0, 32518
AppSec [candidate] (32.919 ms) : 0, 32919
Debugger [baseline] (65.735 ms) : 0, 65735
Debugger [candidate] (66.103 ms) : 0, 66103
Remote Config [baseline] (574.641 µs) : 0, 575
Remote Config [candidate] (572.417 µs) : 0, 572
Telemetry [baseline] (7.886 ms) : 0, 7886
Telemetry [candidate] (7.886 ms) : 0, 7886
Flare Poller [baseline] (3.6 ms) : 0, 3600
Flare Poller [candidate] (3.615 ms) : 0, 3615
ProfilingAgent [baseline] (94.009 ms) : 0, 94009
ProfilingAgent [candidate] (94.132 ms) : 0, 94132
Profiling [baseline] (94.573 ms) : 0, 94573
Profiling [candidate] (94.701 ms) : 0, 94701
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055582
Total [baseline] (8.829 s) : 0, 8829354
Agent [candidate] (1.054 s) : 0, 1054450
Total [candidate] (8.79 s) : 0, 8790432
section iast
Agent [baseline] (1.238 s) : 0, 1237736
Total [baseline] (9.529 s) : 0, 9529071
Agent [candidate] (1.224 s) : 0, 1223741
Total [candidate] (9.513 s) : 0, 9513242
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.234 ms) : 0, 1234
BytebuddyAgent [baseline] (633.022 ms) : 0, 633022
BytebuddyAgent [candidate] (632.226 ms) : 0, 632226
AgentMeter [baseline] (29.209 ms) : 0, 29209
AgentMeter [candidate] (29.404 ms) : 0, 29404
GlobalTracer [baseline] (246.783 ms) : 0, 246783
GlobalTracer [candidate] (248.587 ms) : 0, 248587
AppSec [baseline] (31.789 ms) : 0, 31789
AppSec [candidate] (31.942 ms) : 0, 31942
Debugger [baseline] (59.024 ms) : 0, 59024
Debugger [candidate] (58.99 ms) : 0, 58990
Remote Config [baseline] (596.387 µs) : 0, 596
Remote Config [candidate] (594.261 µs) : 0, 594
Telemetry [baseline] (8.038 ms) : 0, 8038
Telemetry [candidate] (8.015 ms) : 0, 8015
Flare Poller [baseline] (9.823 ms) : 0, 9823
Flare Poller [candidate] (7.397 ms) : 0, 7397
section iast
crashtracking [baseline] (1.236 ms) : 0, 1236
crashtracking [candidate] (1.238 ms) : 0, 1238
BytebuddyAgent [baseline] (813.243 ms) : 0, 813243
BytebuddyAgent [candidate] (800.68 ms) : 0, 800680
AgentMeter [baseline] (11.727 ms) : 0, 11727
AgentMeter [candidate] (11.333 ms) : 0, 11333
GlobalTracer [baseline] (240.26 ms) : 0, 240260
GlobalTracer [candidate] (239.524 ms) : 0, 239524
IAST [baseline] (25.965 ms) : 0, 25965
IAST [candidate] (25.948 ms) : 0, 25948
AppSec [baseline] (30.981 ms) : 0, 30981
AppSec [candidate] (31.091 ms) : 0, 31091
Debugger [baseline] (59.085 ms) : 0, 59085
Debugger [candidate] (60.255 ms) : 0, 60255
Remote Config [baseline] (2.844 ms) : 0, 2844
Remote Config [candidate] (1.172 ms) : 0, 1172
Telemetry [baseline] (12.479 ms) : 0, 12479
Telemetry [candidate] (12.635 ms) : 0, 12635
Flare Poller [baseline] (3.448 ms) : 0, 3448
Flare Poller [candidate] (3.435 ms) : 0, 3435
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section baseline
no_agent (19.813 ms) : 19615, 20012
. : milestone, 19813,
appsec (19.006 ms) : 18816, 19196
. : milestone, 19006,
code_origins (18.043 ms) : 17864, 18221
. : milestone, 18043,
iast (17.809 ms) : 17635, 17983
. : milestone, 17809,
profiling (18.191 ms) : 18008, 18375
. : milestone, 18191,
tracing (18.884 ms) : 18695, 19073
. : milestone, 18884,
section candidate
no_agent (17.998 ms) : 17815, 18181
. : milestone, 17998,
appsec (18.658 ms) : 18470, 18845
. : milestone, 18658,
code_origins (17.909 ms) : 17735, 18084
. : milestone, 17909,
iast (17.791 ms) : 17614, 17969
. : milestone, 17791,
profiling (17.965 ms) : 17789, 18141
. : milestone, 17965,
tracing (18.6 ms) : 18415, 18786
. : milestone, 18600,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section baseline
no_agent (1.221 ms) : 1210, 1233
. : milestone, 1221,
iast (3.351 ms) : 3306, 3397
. : milestone, 3351,
iast_FULL (6.085 ms) : 6023, 6147
. : milestone, 6085,
iast_GLOBAL (3.45 ms) : 3397, 3502
. : milestone, 3450,
profiling (2.244 ms) : 2223, 2265
. : milestone, 2244,
tracing (1.837 ms) : 1822, 1853
. : milestone, 1837,
section candidate
no_agent (1.227 ms) : 1215, 1238
. : milestone, 1227,
iast (3.276 ms) : 3234, 3319
. : milestone, 3276,
iast_FULL (5.927 ms) : 5867, 5987
. : milestone, 5927,
iast_GLOBAL (3.757 ms) : 3696, 3818
. : milestone, 3757,
profiling (2.386 ms) : 2361, 2410
. : milestone, 2386,
tracing (1.908 ms) : 1892, 1925
. : milestone, 1908,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section baseline
no_agent (15.126 s) : 15126000, 15126000
. : milestone, 15126000,
appsec (14.473 s) : 14473000, 14473000
. : milestone, 14473000,
iast (18.004 s) : 18004000, 18004000
. : milestone, 18004000,
iast_GLOBAL (18.199 s) : 18199000, 18199000
. : milestone, 18199000,
profiling (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
tracing (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
section candidate
no_agent (15.533 s) : 15533000, 15533000
. : milestone, 15533000,
appsec (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
iast (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
. : milestone, 17949000,
profiling (15.335 s) : 15335000, 15335000
. : milestone, 15335000,
tracing (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~e9b55d06c7, baseline=1.61.0-SNAPSHOT~aa7c70f2e7
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1500
. : milestone, 1489,
appsec (3.837 ms) : 3614, 4059
. : milestone, 3837,
iast (2.28 ms) : 2210, 2349
. : milestone, 2280,
iast_GLOBAL (2.315 ms) : 2246, 2385
. : milestone, 2315,
profiling (2.115 ms) : 2059, 2170
. : milestone, 2115,
tracing (2.079 ms) : 2025, 2133
. : milestone, 2079,
section candidate
no_agent (1.488 ms) : 1476, 1499
. : milestone, 1488,
appsec (3.836 ms) : 3615, 4058
. : milestone, 3836,
iast (2.27 ms) : 2201, 2339
. : milestone, 2270,
iast_GLOBAL (2.312 ms) : 2242, 2381
. : milestone, 2312,
profiling (2.101 ms) : 2046, 2156
. : milestone, 2101,
tracing (2.086 ms) : 2032, 2140
. : milestone, 2086,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
In #10041 the tracer enforced a minimum agent version of 7.65.0 because this version properly supported container tags propagation. A previous version would improperly propgate those tags and skew the aggregation keys.
However, for serverless there's no host agent; instead, a compatibility layer exists that has a different version history. In order to enable trace computation, this PR proposes to ignore the agent version during feature discovery, via the property
dd.trace.stats.computation.ignore.agent.version.Motivation
Allow enablement of client trace computation in serverless environments.
Additional Notes