Use bitmask SpanKindFilter for per-span eligibility in metrics aggregator #11380
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| package datadog.trace.common.metrics; | ||
|
|
||
| import static datadog.trace.bootstrap.instrumentation.api.Tags.SPAN_KIND; | ||
| import static datadog.trace.bootstrap.instrumentation.api.Tags.SPAN_KIND_CLIENT; | ||
| import static java.util.concurrent.TimeUnit.MICROSECONDS; | ||
| import static java.util.concurrent.TimeUnit.SECONDS; | ||
|
|
||
| import datadog.communication.ddagent.DDAgentFeaturesDiscovery; | ||
| import datadog.trace.api.WellKnownTags; | ||
| import datadog.trace.common.writer.Writer; | ||
| import datadog.trace.core.CoreSpan; | ||
| import datadog.trace.core.CoreTracer; | ||
| import datadog.trace.core.DDSpan; | ||
| import datadog.trace.core.monitor.HealthMetrics; | ||
| import datadog.trace.util.Strings; | ||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import org.openjdk.jmh.annotations.Benchmark; | ||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||
| import org.openjdk.jmh.annotations.Fork; | ||
| import org.openjdk.jmh.annotations.Measurement; | ||
| import org.openjdk.jmh.annotations.Mode; | ||
| import org.openjdk.jmh.annotations.OutputTimeUnit; | ||
| import org.openjdk.jmh.annotations.Scope; | ||
| import org.openjdk.jmh.annotations.State; | ||
| import org.openjdk.jmh.annotations.Warmup; | ||
| import org.openjdk.jmh.infra.Blackhole; | ||
|
|
||
| /** | ||
| * Parallels {@link ConflatingMetricsAggregatorBenchmark} but uses real {@link DDSpan} instances | ||
| * instead of the lightweight {@code SimpleSpan} mock, so the JIT exercises the production {@link | ||
| * CoreSpan#isKind} path (cached span.kind ordinal + bit-test) rather than the groovy mock's | ||
| * dispatch. | ||
| * | ||
| * <p>SpanKindFilter rollout result vs. the pre-bitmask code on master: ~1.3% faster on the | ||
| * production path, with tighter fork-to-fork variance. The CIs overlap so the headline number sits | ||
| * inside noise, but the centers move the right way and the new path is structurally cheaper (byte | ||
| * read + bit-test vs tag-map read + HashSet.contains). <code> | ||
| * MacBook M1 (Java 21), 2 forks x 5 iterations x 15s, AverageTime | ||
| * | ||
| * Branch Score (avg) CI (99.9%) | ||
| * master 6.428 ± 0.189 µs/op [6.239, 6.617] | ||
| * this branch 6.343 ± 0.115 µs/op [6.228, 6.458] | ||
| * </code> | ||
| */ | ||
| @State(Scope.Benchmark) | ||
| @Warmup(iterations = 1, time = 30, timeUnit = SECONDS) | ||
| @Measurement(iterations = 3, time = 30, timeUnit = SECONDS) | ||
| @BenchmarkMode(Mode.AverageTime) | ||
| @OutputTimeUnit(MICROSECONDS) | ||
| @Fork(value = 1) | ||
| public class ConflatingMetricsAggregatorDDSpanBenchmark { | ||
|
|
||
| private static final CoreTracer TRACER = | ||
| CoreTracer.builder().writer(new NoopWriter()).strictTraceWrites(false).build(); | ||
|
|
||
| private final DDAgentFeaturesDiscovery featuresDiscovery = | ||
| new ConflatingMetricsAggregatorBenchmark.FixedAgentFeaturesDiscovery( | ||
| Collections.singleton("peer.hostname"), Collections.emptySet()); | ||
| private final ConflatingMetricsAggregator aggregator = | ||
| new ConflatingMetricsAggregator( | ||
| new WellKnownTags("", "", "", "", "", ""), | ||
| Collections.emptySet(), | ||
| featuresDiscovery, | ||
| HealthMetrics.NO_OP, | ||
| new ConflatingMetricsAggregatorBenchmark.NullSink(), | ||
| 2048, | ||
| 2048, | ||
| false); | ||
| private final List<CoreSpan<?>> spans = generateTrace(64); | ||
|
|
||
| static List<CoreSpan<?>> generateTrace(int len) { | ||
| final List<CoreSpan<?>> trace = new ArrayList<>(); | ||
| for (int i = 0; i < len; i++) { | ||
| DDSpan span = (DDSpan) TRACER.startSpan("benchmark", "op"); | ||
| span.setTag(SPAN_KIND, SPAN_KIND_CLIENT); | ||
| span.setTag("peer.hostname", Strings.random(10)); | ||
| // Fix duration; bypasses the wall clock and avoids per-fork drift. | ||
| span.finishWithDuration(10); | ||
| trace.add(span); | ||
| } | ||
| return trace; | ||
| } | ||
|
|
||
| static class NoopWriter implements Writer { | ||
| @Override | ||
| public void write(List<DDSpan> trace) {} | ||
|
|
||
| @Override | ||
| public void start() {} | ||
|
|
||
| @Override | ||
| public boolean flush() { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public void close() {} | ||
|
|
||
| @Override | ||
| public void incrementDropCounts(int spanCount) {} | ||
| } | ||
|
|
||
| @Benchmark | ||
| public void benchmark(Blackhole blackhole) { | ||
| blackhole.consume(aggregator.publish(spans)); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.