Skip to content

Always download Gradle from MASS in CI#11493

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/move-gradle-distribution-download-to-ci
May 29, 2026
Merged

Always download Gradle from MASS in CI#11493
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
bdu/move-gradle-distribution-download-to-ci

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented May 28, 2026

What Does This Do

Follow-up to #11461, This applies MASS in parts that drive gradle in different versions

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels May 28, 2026
@bric3 bric3 changed the title chore: Always download Gradle from MASS in CI Always download Gradle from MASS in CI May 28, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 28, 2026 •
edited
Loading

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

Commit: cc34d392 · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@datadog-datadog-prod-us1-2

This comment has been minimized.

Sign in to view
@bric3 bric3 force-pushed the bdu/move-gradle-distribution-download-to-ci branch from fd82c55 to 6298111 Compare May 29, 2026 12:50
@bric3
ci(smoke-tests): use MASS for Gradle distributions
d6c1177 
Gradle smoke tests should not reach services.gradle.org from CI. They
now take the MASS read URL as an optional distribution base and keep
the regular Gradle version path for local runs.

The smoke-test plugin, daemon helpers, launcher wrapper rewrite, and
TestKit fixture share the same URL decision. CI Visibility snapshots
are refreshed for the deterministic fixture shape.
@bric3 bric3 force-pushed the bdu/move-gradle-distribution-download-to-ci branch from 6d7fa24 to d6c1177 Compare May 29, 2026 12:57
@bric3 bric3 marked this pull request as ready for review May 29, 2026 13:01
@bric3 bric3 requested review from a team as code owners May 29, 2026 13:01
daniel-mohedano
daniel-mohedano approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@daniel-mohedano daniel-mohedano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Was planning on tackling this myself on SDTEST-3815 so thanks for taking care of it 🚀

AlexeyKuznetsov-DD
AlexeyKuznetsov-DD approved these changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Left minor comment.
Would be nice to see in PR description how tests passed on CI.

Comment thread dd-smoke-tests/gradle/src/test/java/datadog/smoketest/GradleDistribution.java Outdated
@bric3
refactor(smoke-tests): normalize MASS distribution URLs
cc34d39 
Build MASS distribution URLs by first ensuring the base URL ends
with a slash, then appending the artifact path without a leading
slash. The Java and Kotlin helpers now read the same way and the
unit test covers both input shapes.
@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented May 29, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented May 29, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-05-29 13:56:24 UTC ℹ️ Start processing command /merge

2026-05-29 13:56:31 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-05-29 15:33:13 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-05-29 16:42:27 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 858b33c into master May 29, 2026
757 of 759 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/move-gradle-distribution-download-to-ci branch May 29, 2026 16:42
@github-actions github-actions Bot added this to the 1.63.0 milestone May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-mohedano daniel-mohedano daniel-mohedano approved these changes

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bric3 @daniel-mohedano @AlexeyKuznetsov-DD