Skip to content

[codex] Remove no-discovered-test override #11541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bric3 wants to merge 1 commit into from
Closed

[codex] Remove no-discovered-test override #11541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions buildSrc/src/main/kotlin/dd-trace-java.configure-tests.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,6 @@ tasks.withType<Test>().configureEach {
onlyIf("skipForkedTests are undefined or false") { !skipForkedTestsProvider.isPresent }
} else {
exclude("**/*ForkedTest*")
// Starting from Gradle 9.3, Gradle will fail if a test task has no discovered tests.
// While this can be a misconfiguration, dd-trace-java test suite conventions allow suites
// to contain abstract base classes that are extended by concrete forked test suites.
//
// Many instrumentation suites indeed only ship *ForkedTest concrete classes
// (the non-forked peer task created by `addTestSuiteExtendingForDir` exists only
// to host shared configurations/sources). Those test tasks won't have executable tests
// by design under the `**/*ForkedTest*` exclude rule above. So let's allow them.
//
// Related but not the issue here https://github.com/gradle/gradle/issues/36508
failOnNoDiscoveredTests = false
}

// Set test timeout for 20 minutes. Default job timeout is 1h (configured on CI level).
Expand Down