Skip to content

Support Maven generateTestClasspath lookup on 3.6.0+#11577

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
daniel.mohedano/fix-maven-test-classpath
Jun 5, 2026
Merged

Support Maven generateTestClasspath lookup on 3.6.0+#11577
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
daniel.mohedano/fix-maven-test-classpath

Conversation

@daniel-mohedano
Copy link
Copy Markdown
Contributor

What Does This Do

  • Fixes the reflection lookup for AbstractSurefireMojo#generateTestClasspath(). Maven Surefire 3.6.0-M1 changed the signature to AbstractSurefireMojo#generateTestClasspath(ArtifactFilter...), causing the lookup to fail.

Motivation

Additional Notes

test-environment-trigger: skip

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@daniel-mohedano daniel-mohedano added the type: enhancement Enhancements and improvements label Jun 5, 2026
@daniel-mohedano daniel-mohedano requested a review from a team as a code owner June 5, 2026 09:34
@daniel-mohedano daniel-mohedano added the comp: ci visibility Continuous Integration Visibility label Jun 5, 2026
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 5, 2026

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.91 s 13.97 s [-1.7%; +0.8%] (no difference)
startup:insecure-bank:tracing:Agent 12.88 s 12.99 s [-1.8%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.52 s 16.48 s [-0.9%; +1.3%] (no difference)
startup:petclinic:iast:Agent 16.50 s 16.66 s [-1.6%; -0.4%] (maybe better)
startup:petclinic:profiling:Agent 16.49 s 16.45 s [-1.1%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 15.67 s 15.90 s [-2.6%; -0.3%] (maybe better)

Commit: ee5f2939 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@daniel-mohedano
Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jun 5, 2026

View all feedbacks in Devflow UI.

2026-06-05 10:01:51 UTC ℹ️ Start processing command /merge


2026-06-05 10:02:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-06-05 10:12:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-06-05 11:22:46 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 1434d8e into master Jun 5, 2026
574 of 577 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the daniel.mohedano/fix-maven-test-classpath branch June 5, 2026 11:22
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants