Prevent test statistics duplication#11580
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
AlexeyKuznetsov-DD
left a comment
There was a problem hiding this comment.
LGTM. Left one minor notice, safe to ignore.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
|
/merge -f --reason="Do not impact shipped code" |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
This merge request will be merged without running the pre merge checks for of the following reason: Do not impact shipped code.
Warning This change was merged without running any pre merge CI checks Reason: Do not impact shipped code |
ee9a8df
into
master
What Does This Do
Uploads test count JSON files to S3 with a stable logical job key based on the GitLab job slug and split index instead of the retry-specific
CI_JOB_ID.Motivation
This follows up on review feedback from #11579. Retried GitLab jobs keep the same pipeline prefix but get a new job ID, so using
CI_JOB_IDin the S3 object name can leave stale attempts foraggregate_test_countsto download and count.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]