Skip to content

Prevent test statistics duplication#11580

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/dedupe-test-counts-s3-retries
Jun 5, 2026
Merged

Prevent test statistics duplication#11580
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
bdu/dedupe-test-counts-s3-retries

Conversation

@bric3
Copy link
Copy Markdown
Contributor

@bric3 bric3 commented Jun 5, 2026

What Does This Do

Uploads test count JSON files to S3 with a stable logical job key based on the GitLab job slug and split index instead of the retry-specific CI_JOB_ID.

Motivation

This follows up on review feedback from #11579. Retried GitLab jobs keep the same pipeline prefix but get a new job ID, so using CI_JOB_ID in the S3 object name can leave stale attempts for aggregate_test_counts to download and count.

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@bric3 bric3 marked this pull request as ready for review June 5, 2026 13:25
@bric3 bric3 requested review from a team as code owners June 5, 2026 13:25
@bric3 bric3 requested review from amarziali and randomanderson and removed request for a team June 5, 2026 13:25
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 5, 2026

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown
Contributor

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

Check pull requests | Check pull requests   View in Datadog   GitHub Actions

See error Label check failed: at least one type and one component or instrumentation label required for the pull request

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f66a2c9 | Docs | Datadog PR Page | Give us feedback!

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 5, 2026
Copy link
Copy Markdown
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one minor notice, safe to ignore.

Comment thread .gitlab-ci.yml
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented Jun 5, 2026

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.04 s 14.01 s [-0.6%; +1.0%] (no difference)
startup:insecure-bank:tracing:Agent 12.95 s 13.02 s [-1.2%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 16.46 s 16.28 s [-0.4%; +2.7%] (no difference)
startup:petclinic:iast:Agent 16.48 s 15.67 s [-3.8%; +14.1%] (unstable)
startup:petclinic:profiling:Agent 16.48 s 16.58 s [-2.4%; +1.3%] (no difference)
startup:petclinic:tracing:Agent 15.81 s 14.94 s [-2.1%; +13.8%] (unstable)

Commit: f66a2c96 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
Copy link
Copy Markdown
Contributor Author

bric3 commented Jun 5, 2026

/merge -f --reason="Do not impact shipped code"

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 Bot commented Jun 5, 2026

View all feedbacks in Devflow UI.

2026-06-05 14:01:21 UTC ℹ️ Start processing command /merge -f --reason="Do not impact shipped code"


2026-06-05 14:01:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-06-05 14:09:20 UTC ℹ️ MergeQueue: merge request added to the queue without running the checks

This merge request will be merged without running the pre merge checks for of the following reason: Do not impact shipped code.


2026-06-05 14:09:32 UTC ℹ️ MergeQueue: This merge request was merged

Warning

This change was merged without running any pre merge CI checks

Reason: Do not impact shipped code

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit ee9a8df into master Jun 5, 2026
580 of 584 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the bdu/dedupe-test-counts-s3-retries branch June 5, 2026 14:09
@github-actions github-actions Bot added this to the 1.64.0 milestone Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants