Skip to content

Test jvm constraints plugin now configures jmh plugin#12048

Open
bric3 wants to merge 1 commit into
masterfrom
bdu/test-jvm-constraints-apply-to-jmh
Open

Test jvm constraints plugin now configures jmh plugin#12048
bric3 wants to merge 1 commit into
masterfrom
bdu/test-jvm-constraints-apply-to-jmh

Conversation

@bric3

@bric3 bric3 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

What Does This Do

Teach jmh plugin about the testJvm if present, without having to manually wire things in the build-file.

Motivation

This should be a convention. And avoids repetition. E.g. what's done in #11703

Additional Notes

Due to the way classloader works between buildsrc/ and regular projects, the plugin code has to use reflection.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 23, 2026
@bric3

bric3 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 23, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 9f4b41d4dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@datadog-datadog-prod-us1-2

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.95 s 13.86 s [+0.1%; +1.2%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.97 s 12.94 s [-0.8%; +1.1%] (no difference)
startup:petclinic:appsec:Agent 16.95 s 16.72 s [+0.3%; +2.4%] (maybe worse)
startup:petclinic:iast:Agent 16.92 s 16.98 s [-1.2%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.21 s 16.86 s [-8.2%; +0.5%] (no difference)
startup:petclinic:sca:Agent 16.97 s 16.73 s [+0.5%; +2.3%] (maybe worse)
startup:petclinic:tracing:Agent 16.12 s 16.08 s [-0.5%; +1.0%] (no difference)

Commit: 9f4b41d4 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@bric3
bric3 requested a review from dougqh July 23, 2026 13:28
@bric3
bric3 marked this pull request as ready for review July 23, 2026 13:29
@bric3
bric3 requested a review from a team as a code owner July 23, 2026 13:29

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The JMH configuration is now applied centrally without changing the existing testJvm semantics: Gradle's withPlugin callback handles either plugin application order, and an unset testJvm leaves the JMH JVM unset. Focused execution was blocked because this checkout requires a Java 25 Gradle daemon while the sandbox has only JDK 8, 11, 17, and 21.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit 9f4b41d · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant