Add test agent session token support#12050
Conversation
Bits has a CI fix readyWarning This comment is related to an earlier commit. 🟢 Investigated · 🟢 Fix prepared · ⚪ Validation skipped · 🟠 Ready Added the formatter-required blank lines around View in Datadog | Reviewed commit a9bceec · Any feedback? Reach out in #deveng-pr-agent |
a9bceec to
6d68087
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
More details
The new session token is consistently read from DD_TEST_AGENT_SESSION_TOKEN and attached to trace-agent and agent-telemetry requests, while API-key-authenticated intake keeps its existing authentication path. No clear diff-only behavioral regression was identified; focused execution was blocked by the unavailable Gradle download and Java 25 toolchain.
🤖 Datadog Autotest · Commit 6d68087 · What is Autotest? · Any feedback? Reach out in #autotest
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d68087e16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| test_smoke: | ||
| extends: .test_job | ||
| extends: .test_job_with_test_agent |
There was a problem hiding this comment.
Use the session token when checking agent failures
After moving smoke jobs onto the test-agent template, validation still runs .gitlab/check_test_agent_results.sh, whose /test/trace_check/summary and /test/trace_check/failures calls do not pass DD_TEST_AGENT_SESSION_TOKEN. In the shared-agent scenario this feature is meant to support, those endpoints report all sessions when no token is supplied, so an unrelated session's trace-check failure can still fail this job despite the writer tagging its trace requests.
Useful? React with 👍 / 👎.
6d68087 to
775ec98
Compare
What Does This Do
This PR introduces an optional test agent session token for both trace and telemetry writers.
Motivation
The goal is to be able to reuse the existing test agent running in CI but having isolated session.
This will save running multiple test agents to avoid test pollution.
Additional Notes
This PR is part of improving smoke test capabilities.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1247