Remove AgentTracer.noopScope() sentinel#12060
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Removing the exported AgentTracer.noopScope() method is source- and binary-incompatible for custom instrumentations compiled against the current bootstrap API: an upgraded agent can throw NoSuchMethodError when that instrumentation loads or calls the method. The replacement public NoopScope singleton requires downstream recompilation and does not preserve existing callers.
🤖 Datadog Autotest · Commit 5ba19ea · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5ba19eaaf2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🎯 Code Coverage (details) 🔗 Commit SHA: 5ba19ea | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Motivation
This helps with switching between the two context manager approaches, since the checks now don't assume a particular implementation.
Additional Notes
To be merged in once #12008 is merged
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]