Skip to content

🍒 11949 - Fix RUM injection for offset response writes#12064

Open
PerfectSlayer wants to merge 1 commit into
release/v1.64.xfrom
bruce.bujon/backport-pr-11949
Open

🍒 11949 - Fix RUM injection for offset response writes#12064
PerfectSlayer wants to merge 1 commit into
release/v1.64.xfrom
bruce.bujon/backport-pr-11949

Conversation

@PerfectSlayer

Copy link
Copy Markdown
Contributor

Backport #11949 to release/v1.64.x

Add RUM offset write regression coverage

Fix RUM injection for offset writes

Merge branch 'master' into codex/fix-rum-injection-offset-writes

Preserve boundary-spanning RUM injection matches

Refine RUM injection offset writes

Consolidate Spring Boot WebMVC smoke tests

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
(cherry picked from commit 8f323b5)
@PerfectSlayer PerfectSlayer added type: bug fix Bug fix tag: ai generated Largely based on code generated by an AI or LLM comp: rum Realtime User Monitoring tag: override groovy enforcement Override the "Enforce Groovy Migration" check labels Jul 24, 2026
@PerfectSlayer
PerfectSlayer requested review from a team as code owners July 24, 2026 11:58
@PerfectSlayer
PerfectSlayer requested review from manuel-alvarez-alvarez and vandonr and removed request for a team July 24, 2026 11:58

@datadog-datadog-us1-prod datadog-datadog-us1-prod Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The offset-write fix preserves response content and injects exactly once across sliced bulk writes, marker-at-end inputs, and markers split across write boundaries. Direct execution of both byte and character implementations matched a reference injector across 20,000 randomized scenarios; the Gradle test task itself could not start because the wrapper distribution download was unavailable.

Was this helpful? React 👍 or 👎

📊 Validated against 20000 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit bed0fd5 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-us1-prod

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 13.86 s [+0.3%; +1.6%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.97 s 13.00 s [-1.0%; +0.6%] (no difference)
startup:petclinic:appsec:Agent 17.00 s 16.91 s [-0.3%; +1.4%] (no difference)
startup:petclinic:iast:Agent 16.94 s 16.98 s [-1.0%; +0.5%] (no difference)
startup:petclinic:profiling:Agent 16.70 s 16.81 s [-1.8%; +0.5%] (no difference)
startup:petclinic:sca:Agent 16.95 s 16.81 s [-0.1%; +1.8%] (no difference)
startup:petclinic:tracing:Agent 15.66 s 16.15 s [-7.2%; +1.1%] (no difference)

Commit: bed0fd59 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: rum Realtime User Monitoring tag: ai generated Largely based on code generated by an AI or LLM tag: override groovy enforcement Override the "Enforce Groovy Migration" check type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants