🍒 12007 - Fix NoSuchElementException from unchecked Optional.get() in Kafka consumer instrumentation#12066
Open
PerfectSlayer wants to merge 2 commits into
Open
🍒 12007 - Fix NoSuchElementException from unchecked Optional.get() in Kafka consumer instrumentation#12066PerfectSlayer wants to merge 2 commits into
PerfectSlayer wants to merge 2 commits into
Conversation
…sumer instrumentation extractGroup, extractClusterId, and extractBootstrapServers called Optional.get() without checking isPresent()/using orElse(), which threw NoSuchElementException when the underlying consumer group, metadata, or bootstrap servers were not captured. Introduced in 1.64 and observed in production error telemetry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit e20ee61)
Covers the null/empty-Optional cases for extractGroup, extractClusterId, and extractBootstrapServers to prevent regressions of the previously fixed NoSuchElementException. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> (cherry picked from commit 6291883)
PerfectSlayer
added
inst: kafka
PerfectSlayer
requested review from
ValentinZakharov
and removed request for
a team
July 24, 2026 13:14
![datadog-prod-us1-5[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
More details
The helper now safely maps absent consumer-group, metadata, and bootstrap-server optionals to null while preserving present values, and the callback path already uses the same safe behavior. No diff-only behavioral regression was identified; local execution was blocked before compilation by the unavailable Java 25 toolchain.
🤖 Datadog Autotest · Commit 220be5d · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
mhdatie
approved these changes
Jul 24, 2026
Contributor
|
🎯 Code Coverage (details) 🔗 Commit SHA: 220be5d | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #12007 to release/v1.64.x