Skip to content

🍒 12028 - Stamp _dd.apm.enabled on every exported chunk when APM tracing is disabled#12068

Open
claponcet wants to merge 1 commit into
release/v1.64.xfrom
clara.poncet/backport-pr-12028
Open

🍒 12028 - Stamp _dd.apm.enabled on every exported chunk when APM tracing is disabled#12068
claponcet wants to merge 1 commit into
release/v1.64.xfrom
clara.poncet/backport-pr-12028

Conversation

@claponcet

Copy link
Copy Markdown
Contributor

Backport #12028 to release/v1.64.x

…abled (#12028)

Stamp _dd.apm.enabled on every exported chunk when APM tracing is disabled

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Mark the root-most span of each exported chunk with _dd.apm.enabled:0

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Cover root-less chunk fallback in ApmTracingDisabledChunkMarkerTest

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Correct getLocalRootSpanTags comment to say root-most span

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

add standalone tag on every single span

Tighten smoke-test to every-span assertion and clarify apmTracingEnabled javadoc

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Merge branch 'master' into clara.poncet/apm-enabled-service-entry-span

fix late outbound controller

formatting

Co-authored-by: devflow.devflow-routing-intake <devflow.devflow-routing-intake@kubernetes.us1.ddbuild.io>
(cherry picked from commit 6821684)
@claponcet
claponcet requested review from a team as code owners July 24, 2026 16:03
@dd-octo-sts dd-octo-sts Bot added the tag: ai generated Largely based on code generated by an AI or LLM label Jul 24, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The export-path change correctly applies _dd.apm.enabled:0 after sampling to every span in every accepted chunk, including rootless late-child and partial-flush chunks, while leaving APM-enabled traces unchanged. The targeted test could not execute in this sandbox because Java 25 is unavailable and Gradle downloads are blocked; source review found no clear behavioral regression.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit d514187 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@dd-octo-sts

dd-octo-sts Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 14.00 s [-0.6%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.92 s 13.01 s [-1.3%; +0.1%] (no difference)
startup:petclinic:appsec:Agent 17.48 s 17.06 s [+1.4%; +3.4%] (significantly worse)
startup:petclinic:iast:Agent 17.26 s 16.93 s [-2.4%; +6.3%] (no difference)
startup:petclinic:profiling:Agent 17.37 s 17.25 s [-0.9%; +2.3%] (no difference)
startup:petclinic:sca:Agent 17.54 s 17.37 s [+0.2%; +1.7%] (maybe worse)
startup:petclinic:tracing:Agent 16.57 s 16.54 s [-0.7%; +1.2%] (no difference)

Commit: d5141875 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: ai generated Largely based on code generated by an AI or LLM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant