Skip to content

feat(startup-log): report OTLP export status#9517

Open
bm1549 wants to merge 2 commits into
masterfrom
brian.marks/otlp-export-startup-log
Open

feat(startup-log): report OTLP export status#9517
bm1549 wants to merge 2 commits into
masterfrom
brian.marks/otlp-export-startup-log

Conversation

@bm1549

@bm1549 bm1549 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds three boolean fields to the DATADOG TRACER CONFIGURATION startup log that report whether the tracer exports each telemetry signal over OTLP:

  • otlp_traces_export_enabledtrue when OTEL_TRACES_EXPORTER is otlp and the tracer isn't running in Test Optimization mode (Test Optimization keeps test spans on the citestcycle endpoint instead of OTLP).
  • otlp_metrics_export_enabled — reflects DD_METRICS_OTEL_ENABLED.
  • otlp_logs_export_enabled — reflects DD_LOGS_OTEL_ENABLED.

The startup-log spec is updated to cover the new fields, the Test Optimization case, and the default all-false state.

Motivation

Part of a cross-tracer effort to surface OTLP export status uniformly. Each dd-trace library emits the same JSON keys in its startup log, so the state reads the same way regardless of language.

Additional Notes

The values mirror the tracer's actual export behavior rather than the raw environment variables: the traces flag applies the same !isCiVisibility guard the exporter uses, and the metrics/logs flags read the config values the OTLP pipelines gate on.


Related PRs — cross-tracer OTLP startup-log effort


CI note

The integration-webpack (node-active / node-latest) failures are pre-existing and unrelated to this change: the webpack test fixture's npm run build fails resolving a transitive dependency (@ljharb/tsconfig). The same two jobs fail intermittently on master, and the other Node versions (oldest/maintenance) pass. Not introduced by this PR.

Add three boolean fields to the DATADOG TRACER CONFIGURATION startup log
indicating whether the tracer exports each telemetry signal over OTLP:

- otlp_traces_export_enabled  (OTEL_TRACES_EXPORTER === 'otlp', excluding
  Test Optimization mode, which keeps test spans on the citestcycle endpoint)
- otlp_metrics_export_enabled (DD_METRICS_OTEL_ENABLED)
- otlp_logs_export_enabled    (DD_LOGS_OTEL_ENABLED)

The snake_case keys are chosen for cross-language startup-log consistency.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@bm1549 bm1549 added the AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos label Jul 24, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 7.52 MB
Deduped: 8.18 MB
No deduping: 8.18 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.2 | 124.41 kB | 440.65 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 24, 2026

Copy link
Copy Markdown

Pipelines  Tests

⚠️ Warnings

🚦 2 Pipeline jobs failed

All Green | all-green   View in Datadog   GitHub Actions

🧪 4 Tests failed

Plugin aws-sdk (lambda) with @aws-sdk/smithy-client &gt;=3 (3.374.0) with the new trace context propagation service and operation naming (client) in version v0 should conform to the naming schema from in version v0   View in Datadog
Invalid time value

RangeError: Invalid time value
    at Date.toISOString (&lt;anonymous&gt;)
    at iso8601 (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:203:6)
    at SignatureV4.formatDate (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:281:26)
    at SignatureV4.signRequest (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:498:46)
    at async AwsSdkSigV4Signer.sign (versions/node_modules/@aws-sdk/core/dist-cjs/submodules/httpAuthSchemes/index.js:72:31)
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/index.js:120:18
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/submodules/retry/index.js:170:50
...
Plugin aws-sdk (lambda) with @aws-sdk/smithy-client &gt;=3 (3.374.0) with the new trace context propagation service and operation naming (invoke) service naming short-circuit in v0 should pass service name through from service naming short-circuit in v0   View in Datadog
Invalid time value

RangeError: Invalid time value
    at Date.toISOString (&lt;anonymous&gt;)
    at iso8601 (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:203:6)
    at SignatureV4.formatDate (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:281:26)
    at SignatureV4.signRequest (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:498:46)
    at async AwsSdkSigV4Signer.sign (versions/node_modules/@aws-sdk/core/dist-cjs/submodules/httpAuthSchemes/index.js:72:31)
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/index.js:120:18
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/submodules/retry/index.js:170:50
...
View all failed tests

Serverless | aws-sdk (latest, lambda)   View in Datadog   GitHub Actions

🧪 5 Tests failed in 1 job

All Green | all-green   GitHub Actions

Plugin aws-sdk (lambda) with @aws-sdk/smithy-client &gt;=3 (3.374.0) with the new trace context propagation service and operation naming (invoke) in version v0 should conform to the naming schema from in version v0   View in Datadog
Invalid time value

RangeError: Invalid time value
    at Date.toISOString (&lt;anonymous&gt;)
    at iso8601 (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:203:6)
    at SignatureV4.formatDate (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:281:26)
    at SignatureV4.signRequest (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:498:46)
    at async AwsSdkSigV4Signer.sign (versions/node_modules/@aws-sdk/core/dist-cjs/submodules/httpAuthSchemes/index.js:72:31)
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/index.js:120:18
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/submodules/retry/index.js:170:50
...
Plugin aws-sdk (lambda) with @aws-sdk/smithy-client &gt;=3 (3.374.0) with the new trace context propagation service and operation naming (client) in version v1 should conform to the naming schema from in version v1   View in Datadog
Invalid time value

RangeError: Invalid time value
    at Date.toISOString (&lt;anonymous&gt;)
    at iso8601 (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:203:6)
    at SignatureV4.formatDate (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:281:26)
    at SignatureV4.signRequest (versions/node_modules/@smithy/signature-v4/dist-cjs/index.js:498:46)
    at async AwsSdkSigV4Signer.sign (versions/node_modules/@aws-sdk/core/dist-cjs/submodules/httpAuthSchemes/index.js:72:31)
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/index.js:120:18
    at async /home/runner/work/dd-trace-js/dd-trace-js/versions/node_modules/@smithy/core/dist-cjs/submodules/retry/index.js:170:50
...

View all failed tests

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 0 passed on retry View in Datadog

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 98.45% (+0.06%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1ccdd76 | Docs | Datadog PR Page | Give us feedback!

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.45%. Comparing base (b37c68d) to head (1ccdd76).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9517      +/-   ##
==========================================
+ Coverage   98.39%   98.45%   +0.06%     
==========================================
  Files         947      947              
  Lines      128041   128066      +25     
  Branches    11091    11056      -35     
==========================================
+ Hits       125987   126090     +103     
+ Misses       2054     1976      -78     
Flag Coverage Δ
aiguard 57.49% <100.00%> (-0.03%) ⬇️
aiguard-integration 56.34% <100.00%> (+<0.01%) ⬆️
apm-bucket-0 57.74% <100.00%> (-0.03%) ⬇️
apm-bucket-1 64.02% <100.00%> (-0.02%) ⬇️
apm-bucket-2 62.79% <100.00%> (-2.15%) ⬇️
apm-bucket-3 60.23% <100.00%> (-1.59%) ⬇️
apm-capabilities-tracing 64.32% <100.00%> (+0.01%) ⬆️
apm-integrations-aerospike 56.83% <100.00%> (-0.03%) ⬇️
apm-integrations-confluentinc-kafka-javascript 61.64% <100.00%> (-0.06%) ⬇️
apm-integrations-couchbase 57.18% <100.00%> (-0.03%) ⬇️
apm-integrations-http 62.80% <100.00%> (-0.02%) ⬇️
apm-integrations-kafkajs 62.28% <100.00%> (?)
apm-integrations-next 59.27% <100.00%> (-0.02%) ⬇️
apm-integrations-prisma 58.76% <100.00%> (?)
apm-integrations-sharedb_integrations-tedious ?
appsec 72.93% <100.00%> (-0.03%) ⬇️
appsec-express_fastify_graphql 70.41% <100.00%> (-0.02%) ⬇️
appsec-integration 51.51% <100.00%> (+0.15%) ⬆️
appsec-kafka_ldapjs_lodash 64.01% <100.00%> (-0.02%) ⬇️
appsec-mongodb-core_mongoose_mysql 67.72% <100.00%> (-0.02%) ⬇️
appsec-next 57.61% <100.00%> (-0.02%) ⬇️
appsec-node-serialize_passport_postgres 67.39% <100.00%> (-0.02%) ⬇️
appsec-sourcing_stripe_template 65.74% <100.00%> (-0.02%) ⬇️
debugger 64.94% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-0 51.84% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-1 60.32% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-10 62.12% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-11 51.75% <100.00%> (-0.03%) ⬇️
instrumentations-bucket-12 52.32% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-13 51.86% <100.00%> (-0.03%) ⬇️
instrumentations-bucket-2 53.75% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-3 59.32% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-4 52.41% <100.00%> (-0.03%) ⬇️
instrumentations-bucket-5 57.65% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-6 60.85% <100.00%> (-0.03%) ⬇️
instrumentations-bucket-7 58.52% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-8 59.66% <100.00%> (-0.02%) ⬇️
instrumentations-bucket-9 61.64% <100.00%> (-0.02%) ⬇️
instrumentations-instrumentation-couchbase 51.15% <100.00%> (-0.03%) ⬇️
instrumentations-integration-esbuild 34.27% <0.00%> (-0.01%) ⬇️
llmobs-ai_anthropic_bedrock 62.90% <100.00%> (-0.02%) ⬇️
llmobs-bucket-1 61.71% <100.00%> (-0.02%) ⬇️
llmobs-openai 62.44% <100.00%> (-0.02%) ⬇️
llmobs-openai-agents_vertex-ai 59.80% <100.00%> (-0.01%) ⬇️
llmobs-sdk 65.60% <100.00%> (-0.03%) ⬇️
master-coverage 98.45% <100.00%> (?)
openfeature 56.19% <100.00%> (-0.01%) ⬇️
openfeature-unit 53.48% <100.00%> (-0.05%) ⬇️
platform-core_esbuild_instrumentations-misc 40.64% <100.00%> (-0.02%) ⬇️
platform-integration 61.50% <100.00%> (+<0.01%) ⬆️
platform-shimmer_unit-guardrails_webpack 39.27% <100.00%> (-0.02%) ⬇️
plugins-bucket-0 57.15% <100.00%> (-0.02%) ⬇️
plugins-bucket-1 54.45% <100.00%> (+<0.01%) ⬆️
plugins-bucket-11 62.36% <100.00%> (+0.39%) ⬆️
plugins-bucket-14 ?
plugins-bucket-17 ?
plugins-bucket-18 62.06% <100.00%> (+3.44%) ⬆️
plugins-bucket-19 60.15% <100.00%> (-1.73%) ⬇️
plugins-bucket-20 62.15% <100.00%> (-0.26%) ⬇️
plugins-bucket-4 58.68% <100.00%> (-0.02%) ⬇️
plugins-bullmq_cassandra_cookie 61.85% <100.00%> (-0.02%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 56.84% <100.00%> (-0.03%) ⬇️
plugins-fetch_fs_generic-pool 58.88% <100.00%> (-0.02%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 64.78% <100.00%> (-0.02%) ⬇️
plugins-hapi_hono_ioredis 60.33% <100.00%> (-0.02%) ⬇️
plugins-jest_knex_langgraph 55.71% <100.00%> (?)
plugins-jest_langgraph_ldapjs ?
plugins-ldapjs_light-my-request_limitd-client 58.61% <100.00%> (?)
plugins-light-my-request_limitd-client_lodash ?
plugins-lodash_mariadb_memcached 58.19% <100.00%> (?)
plugins-mariadb_memcached_mercurius ?
plugins-moleculer_mongodb_mongodb-core 62.01% <100.00%> (?)
plugins-mongodb-core_mongoose_multer ?
plugins-mongoose_multer_mysql 59.19% <100.00%> (?)
plugins-mysql2_nats_node-serialize 60.82% <100.00%> (?)
plugins-mysql_mysql2_nats ?
plugins-opensearch_passport-http_pino 59.65% <100.00%> (?)
plugins-pino_postgres_process ?
plugins-postgres_process_pug 58.39% <100.00%> (?)
plugins-pug_redis_router ?
plugins-redis_router_sequelize 62.20% <100.00%> (?)
plugins-test-and-upstream-rhea_undici_url 61.73% <100.00%> (?)
plugins-url_valkey_vm ?
plugins-valkey_vm_winston 58.12% <100.00%> (?)
plugins-winston_ws ?
plugins-ws 59.70% <100.00%> (?)
profiling 62.24% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-aws-sdk 55.15% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-bedrockruntime 54.87% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-client 56.54% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-dynamodb 55.77% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-eventbridge 49.49% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-kinesis 59.44% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-lambda ?
serverless-aws-sdk-s3 55.86% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-serverless-peer-service 59.84% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-sns 60.30% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-sqs 60.72% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-stepfunctions 55.69% <100.00%> (-0.02%) ⬇️
serverless-aws-sdk-util 51.59% <100.00%> (-0.03%) ⬇️
serverless-bucket-0 58.90% <100.00%> (+4.55%) ⬆️
serverless-bucket-1 53.78% <100.00%> (-5.60%) ⬇️
serverless-lambda 56.12% <100.00%> (?)
test-optimization-cucumber 72.03% <0.00%> (+0.05%) ⬆️
test-optimization-cypress 65.86% <0.00%> (+0.10%) ⬆️
test-optimization-jest 73.34% <100.00%> (+0.01%) ⬆️
test-optimization-mocha 73.53% <100.00%> (+0.05%) ⬆️
test-optimization-playwright-playwright-atr 60.46% <0.00%> (+<0.01%) ⬆️
test-optimization-playwright-playwright-efd 60.64% <0.00%> (+0.01%) ⬆️
test-optimization-playwright-playwright-final-status 60.61% <0.00%> (+0.01%) ⬆️
test-optimization-playwright-playwright-impacted-tests 60.34% <0.00%> (+0.17%) ⬆️
test-optimization-playwright-playwright-reporting 61.64% <0.00%> (-0.10%) ⬇️
test-optimization-playwright-playwright-test-management 61.15% <0.00%> (+0.19%) ⬆️
test-optimization-playwright-playwright-test-span 60.56% <0.00%> (-0.06%) ⬇️
test-optimization-selenium 60.12% <0.00%> (-0.14%) ⬇️
test-optimization-testopt 58.57% <100.00%> (+0.08%) ⬆️
test-optimization-vitest 70.32% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Jul 24, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-24 22:57:01

Comparing candidate commit 1ccdd76 in PR branch brian.marks/otlp-export-startup-log with baseline commit b37c68d in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2324 metrics, 34 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-203.858ms; +210.498ms] or [-7.627%; +7.876%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-243132.187µs; +241813.254µs] or [-9.532%; +9.480%]

scenario:appsec-appsec-enabled-with-attacks-24

  • unstable execution_time [-161968.816µs; +160299.483µs] or [-5.215%; +5.161%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-193.221ms; +186.876ms] or [-6.649%; +6.431%]

scenario:appsec-control-20

  • unstable execution_time [-115.678ms; +130.220ms] or [-7.076%; +7.965%]

scenario:appsec-control-24

  • unstable execution_time [-113.829ms; +117.509ms] or [-9.107%; +9.402%]

scenario:appsec-control-26

  • unstable execution_time [-122267.190µs; +122319.223µs] or [-9.874%; +9.878%]

scenario:appsec-iast-no-vulnerability-control-20

  • unstable execution_time [-10.547ms; +23.357ms] or [-4.019%; +8.900%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-12.286ms; +18.728ms] or [-4.728%; +7.207%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-15188.103µs; +16324.036µs] or [-5.963%; +6.408%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-27.153ms; +30.026ms] or [-4.917%; +5.438%]

scenario:child_process-shell-string-24

  • unstable execution_time [-14.000ms; +25.074ms] or [-4.285%; +7.675%]
  • unstable throughput [-224319.956op/s; +144719.177op/s] or [-6.252%; +4.034%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-2852.673ms; +2822.827ms] or [-32.091%; +31.755%]
  • unstable execution_time [-2922.476ms; +2925.923ms] or [-30.438%; +30.474%]
  • unstable instructions [-23790.3M instructions; +23865.8M instructions] or [-32.713%; +32.816%]
  • unstable max_rss_usage [-11398.774KB; +11500.374KB] or [-7.149%; +7.212%]
  • unstable throughput [-761.726op/s; +776.125op/s] or [-21.722%; +22.133%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-2.093s; +4.461s] or [-23.556%; +50.218%]
  • unstable execution_time [-2.185s; +4.558s] or [-22.770%; +47.510%]
  • unstable instructions [-17.6G instructions; +37.8G instructions] or [-24.184%; +51.974%]
  • unstable max_rss_usage [-8.974MB; +18.855MB] or [-5.628%; +11.824%]
  • unstable throughput [-1201.517op/s; +589.074op/s] or [-34.223%; +16.779%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-312.142ms; +382.974ms] or [-6.451%; +7.915%]
  • unstable execution_time [-313.500ms; +380.674ms] or [-6.381%; +7.748%]
  • unstable throughput [-135410.357op/s; +112150.909op/s] or [-7.922%; +6.561%]

scenario:plugin-aws-sdk-lambda-inject-with-context-24

  • unstable cpu_user_time [-194.289ms; +199.154ms] or [-5.082%; +5.209%]
  • unstable execution_time [-188.698ms; +200.604ms] or [-4.904%; +5.213%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-20

  • unstable max_rss_usage [-18.329MB; +29.262MB] or [-4.704%; +7.510%]

scenario:plugin-graphql-long-with-depth-off-26

  • unstable max_rss_usage [-31.251MB; +28.866MB] or [-14.953%; +13.812%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable throughput [-3.135op/s; +3.671op/s] or [-4.638%; +5.431%]

scenario:plugin-memcached-hashring-24

  • unstable execution_time [-156.914ms; +212.289ms] or [-6.105%; +8.260%]
  • unstable throughput [-911387.017op/s; +712659.572op/s] or [-6.112%; +4.779%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-3.370MB; +8.528MB] or [-4.206%; +10.642%]

@bm1549
bm1549 marked this pull request as ready for review July 24, 2026 21:41
@bm1549
bm1549 requested a review from a team as a code owner July 24, 2026 21:41
@bm1549
bm1549 requested review from khanayan123 and removed request for a team July 24, 2026 21:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9444363f82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +326 to +328
delete process.env.OTEL_TRACES_EXPORTER
delete process.env.DD_METRICS_OTEL_ENABLED
delete process.env.DD_LOGS_OTEL_ENABLED

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear all OTLP exporter env vars in the startup-log tests

In shells that already set OTEL_METRICS_EXPORTER=none, this cleanup leaves that value in place, so the new metrics case calls getConfigFresh() with DD_METRICS_OTEL_ENABLED=true but config calculation disables it again and the asserted otlp_metrics_export_enabled value is no longer true. Clear the sibling OTEL exporter vars here as well, at least OTEL_METRICS_EXPORTER, before the tests set the DD_* toggles.

AGENTS.md reference: AGENTS.md:L98-L102

Useful? React with 👍 / 👎.

…ag tests

The `otlp export flags` cleanup only cleared OTEL_TRACES_EXPORTER, leaving
OTEL_METRICS_EXPORTER and OTEL_LOGS_EXPORTER set. In shells that export
OTEL_METRICS_EXPORTER=none, config forces DD_METRICS_OTEL_ENABLED back to
false, so the metrics positive case no longer observes the enabled flag.
Clear all three OTEL_*_EXPORTER selectors in the shared cleanup so the
tests are deterministic regardless of the surrounding shell.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Generated Largely based on code generated by an AI or LLM. This label is the same across all dd-trace-* repos semver-minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant