Skip to content

Fix #3651: Prevent crash during shutdown in Frankenphp #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwoebi wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

Fix #3651: Prevent crash during shutdown in Frankenphp #3662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ext/signals.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,20 @@ static int dd_call_prev_handler(bool flush) {
}

static int dd_sigterm_cleanup_thread(void *arg) {
// Block all signals to prevent delivery to this thread
sigset_t set;
sigfillset(&set);
sigprocmask(SIG_BLOCK, &set, NULL);

// Make the Go runtime believe, we are actually running on a signal stack
stack_t altstack;
altstack.ss_sp = dd_signal_async_stack;
if (altstack.ss_sp) {
altstack.ss_size = dd_signal_async_stack_size;
altstack.ss_flags = 0;
sigaltstack(&altstack, NULL);
}

return dd_call_prev_handler(true);
}

Expand Down
Loading