fix(test): stabilize crashtracker_segfault_disabled test and isolate RC requests in request-replayer#3668
Open
fix(test): stabilize crashtracker_segfault_disabled test and isolate RC requests in request-replayer#3668
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3668 +/- ##
==========================================
- Coverage 62.19% 62.17% -0.02%
==========================================
Files 141 141
Lines 13352 13352
Branches 1746 1746
==========================================
- Hits 8304 8302 -2
- Misses 4256 4259 +3
+ Partials 792 791 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e4fbacc to
84fd1d7
Compare
bwoebi
approved these changes
Feb 25, 2026
c62d5f4 to
af5d446
Compare
af5d446 to
693878e
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…properly filter Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…able Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
… non-debug request-replayer - Add 2>/dev/null to silence segfault output from child process on stdout - Switch CI to use php-request-replayer-2.0 instead of the debug variant
693878e to
584ffcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
crashtracker_segfault_disabled.phptwas flaking because commit32aaf0a7bstarted writing/v0.7/configremote-config poll requests into the same dump file as telemetry. This caused the test's broad matcher to find false positives and never time out as expected.Fix
Request-replayer:
/v0.7/configrequests are now written to a dedicatedrc_requests.jsonfile and exposed via a new/replay-rc-requestsendpoint, keeping/replayuncontaminated by RC traffic.Test rewrite: replaced the fragile timeout-based negative assertion with a bounded 5 s poll that looks for
is_crash: truein telemetry logs — the definitive indicator that a crash report was sent. Also addedclearDumpedData()before the test runs to avoid stale entries, and suppressed segfault stderr output (2>/dev/null) so the--EXPECT--check is not polluted by the shell message.