ci: fix package-oci failure in parent pipeline#3679
Open
Conversation
Commit a3409cd included one-pipeline.locked.yml in the parent pipeline to get the supported-configurations validation job templates. This accidentally also brought in the package-oci job, which has no needs: and therefore no access to the package loader artifacts. Before that commit, package-oci only ran in the child pipeline (package-gen.yml) where generate-package.php overrides its needs: to depend on the package loader jobs. The fix restores the original behavior by suppressing package-oci in the parent pipeline.
1237da2 to
9154809
Compare
Commit a3409cd included one-pipeline.locked.yml in the parent pipeline to get the supported-configurations validation job templates. This accidentally also brought in shared-pipeline jobs (package-oci and its downstream) which have no access to the package loader artifacts. Fix: set SKIP_SHARED_PIPELINE=true globally in the parent pipeline so all shared-pipeline jobs from one-pipeline.yml that check this variable are suppressed. Override it to false in package-trigger so the child pipeline (package-gen.yml) still runs package-oci correctly with its needs: [package loader] override. Also suppress requirements_json_test explicitly since it does not check SKIP_SHARED_PIPELINE (it only checks DANGEROUSLY_SKIP_SHARED_PIPELINE_TESTS). It runs correctly in the child pipeline via generate-package.php overrides.
e8cc03c to
45910a1
Compare
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3679 +/- ##
==========================================
- Coverage 62.20% 62.17% -0.03%
==========================================
Files 141 141
Lines 13352 13352
Branches 1746 1746
==========================================
- Hits 8305 8302 -3
- Misses 4256 4259 +3
Partials 791 791 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
Commit a3409cd included
one-pipeline.locked.ymlin the parent pipeline to get the supported-configurations validation templates. This accidentally also brought inpackage-ociand its downstream jobs, which have no access topackage loaderartifacts in the parent pipeline.package-ociis meant to run only in the child pipeline (viapackage-trigger) wheregenerate-package.phpprovides the correctneeds: [package loader]override.Fix
SKIP_SHARED_PIPELINE: "true"globally to suppress shared-pipeline jobs in the parent pipeline."false"inpackage-triggerso the child pipeline still runs them correctly.requirements_json_testsince it doesn't checkSKIP_SHARED_PIPELINE.Reviewer checklist