Skip to content

ci: fix package-oci failure in parent pipeline#3679

Open
Leiyks wants to merge 2 commits intomasterfrom
leiyks/fix-package-oci-failure
Open

ci: fix package-oci failure in parent pipeline#3679
Leiyks wants to merge 2 commits intomasterfrom
leiyks/fix-package-oci-failure

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Feb 26, 2026

Root Cause

Commit a3409cd included one-pipeline.locked.yml in the parent pipeline to get the supported-configurations validation templates. This accidentally also brought in package-oci and its downstream jobs, which have no access to package loader artifacts in the parent pipeline.

package-oci is meant to run only in the child pipeline (via package-trigger) where generate-package.php provides the correct needs: [package loader] override.

Fix

  • Set SKIP_SHARED_PIPELINE: "true" globally to suppress shared-pipeline jobs in the parent pipeline.
  • Override to "false" in package-trigger so the child pipeline still runs them correctly.
  • Explicitly suppress requirements_json_test since it doesn't check SKIP_SHARED_PIPELINE.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Commit a3409cd included one-pipeline.locked.yml in the parent pipeline
to get the supported-configurations validation job templates. This
accidentally also brought in the package-oci job, which has no needs:
and therefore no access to the package loader artifacts.

Before that commit, package-oci only ran in the child pipeline
(package-gen.yml) where generate-package.php overrides its needs: to
depend on the package loader jobs. The fix restores the original
behavior by suppressing package-oci in the parent pipeline.
@Leiyks Leiyks force-pushed the leiyks/fix-package-oci-failure branch from 1237da2 to 9154809 Compare February 26, 2026 21:43
Commit a3409cd included one-pipeline.locked.yml in the parent pipeline
to get the supported-configurations validation job templates. This
accidentally also brought in shared-pipeline jobs (package-oci and its
downstream) which have no access to the package loader artifacts.

Fix: set SKIP_SHARED_PIPELINE=true globally in the parent pipeline so
all shared-pipeline jobs from one-pipeline.yml that check this variable
are suppressed. Override it to false in package-trigger so the child
pipeline (package-gen.yml) still runs package-oci correctly with its
needs: [package loader] override.

Also suppress requirements_json_test explicitly since it does not check
SKIP_SHARED_PIPELINE (it only checks DANGEROUSLY_SKIP_SHARED_PIPELINE_TESTS).
It runs correctly in the child pipeline via generate-package.php overrides.
@Leiyks Leiyks force-pushed the leiyks/fix-package-oci-failure branch from e8cc03c to 45910a1 Compare February 26, 2026 21:51
@datadog-official
Copy link

datadog-official bot commented Feb 26, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69a0c27800000000e661e4184945c11a
tid: 69a0c27800000000
hexProcessTraceId: e661e4184945c11a
hexProcessSpanId: ce621635e1d2925f
processTraceId: 16600800494424015130
processSpanId: 14871473340208550495

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 45910a1 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@Leiyks Leiyks changed the title ci: suppress package-oci in parent pipeline ci: fix package-oci failure in parent pipeline Feb 26, 2026
@Leiyks Leiyks marked this pull request as ready for review February 26, 2026 22:53
@Leiyks Leiyks requested a review from a team as a code owner February 26, 2026 22:53
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.17%. Comparing base (6733f8f) to head (45910a1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3679      +/-   ##
==========================================
- Coverage   62.20%   62.17%   -0.03%     
==========================================
  Files         141      141              
  Lines       13352    13352              
  Branches     1746     1746              
==========================================
- Hits         8305     8302       -3     
- Misses       4256     4259       +3     
  Partials      791      791              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6733f8f...45910a1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants