Skip to content

runtime iseqs wip#4540

Closed
p-datadog wants to merge 15 commits intomasterfrom
runtime-iseqs
Closed

runtime iseqs wip#4540
p-datadog wants to merge 15 commits intomasterfrom
runtime-iseqs

Conversation

@p-datadog
Copy link
Copy Markdown
Member

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@github-actions
Copy link
Copy Markdown

👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-03-27 19:48:31 UTC

@datadog-datadog-prod-us1
Copy link
Copy Markdown
Contributor

datadog-datadog-prod-us1 bot commented Mar 27, 2025

Datadog Report

Branch report: runtime-iseqs
Commit report: 1b39a26
Test service: dd-trace-rb

❌ 1 Failed (0 Known Flaky), 20756 Passed, 1348 Skipped, 3m 37.13s Total Time
❄️ 1 New Flaky

❌ Failed Tests (1)

  • all_iseqs returns iseqs for all required files - rspec - Details

    Expand for error
     cannot load such file -- libdatadog_api.3.3_x86_64-linux
     
     Failure/Error: require 'libdatadog_api.3.3_x86_64-linux'
     
     LoadError:
       cannot load such file -- libdatadog_api.3.3_x86_64-linux
     ./spec/datadog/di/loaded_file_iseq_spec.rb:5:in 'block (2 levels) in <top (required)>'
    

New Flaky Tests (1)

  • all_iseqs returns iseqs - rspec - Last Failure

    Expand for error
     cannot load such file -- libdatadog_api.3.3_x86_64-linux
     
     Failure/Error: require 'libdatadog_api.3.3_x86_64-linux'
     
     LoadError:
       cannot load such file -- libdatadog_api.3.3_x86_64-linux
     ./spec/datadog/di/loaded_file_iseq_spec.rb:5:in 'block (2 levels) in <top (required)>'
    

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 27, 2025

Benchmarks

Benchmark execution time: 2025-04-14 18:03:34

Comparing candidate commit 1b39a26 in PR branch runtime-iseqs with baseline commit d70b89c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@ivoanjo
Copy link
Copy Markdown
Member

ivoanjo commented May 2, 2025

Btw, in part to avoid weird conflicts in the future, I've worked with @vpellan to get his #4561 PR in master, which also introduces an init.c. So for this PR it should be as easy as adopting that file as well.

@p-datadog
Copy link
Copy Markdown
Member Author

Superseded by #5111

@p-datadog p-datadog closed this Dec 5, 2025
@p-datadog p-datadog deleted the runtime-iseqs branch December 5, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants