enable process tags to true by default#5432
Conversation
…true and adjust tests
|
Thank you for updating Change log entry section 👏 Visited at: 2026-03-09 23:03:42 UTC |
…t needed for the test
BenchmarksBenchmark execution time: 2026-03-13 21:16:34 Comparing candidate commit 8e27c3e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 0 unstable metrics.
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 8e27c3e | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
ivoanjo
left a comment
There was a problem hiding this comment.
Left a few notes!
if we're going to set this to "true", I think DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED is a poor name for the config to override it so I'll ask if there should be an alias since we'll likely want to document this new setting.
+1 on this one -- if this is no longer experimental we should probably deprecate the old flag (but not a blocker for this PR)
…tags are disabled to avoid mixing testing concerns
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
ivoanjo
left a comment
There was a problem hiding this comment.
👍 Looks reasonable! Left one last round of suggestions
… include experimental and adjust specs to match
ivoanjo
left a comment
There was a problem hiding this comment.
Spotted a few more weird things!
What does this PR do?
Sets DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED to true so that the process tags are always collected by default. (This will support other initiatives)
Motivation:
The other tracers are also doing this:
Change log entry
Yes. Enables process tags for Tracing, Database Monitoring, Data Streams Monitoring, Profiling, Runtime Metrics, Process Discovery, Remote Configuration, Telemetry, Dynamic Instrumentation, and CrashTracking.
Additional Notes:
Yes. I'm currently trying to understand the expectations around:
- Answer: From checking with the team, we'll leave this DBM behavior alone.
- Answer: From checking with the rest of my team working on this feature, we'll leave it as DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED for now. There are no plans to alias it.
How to test the change?
When I made the other PRs, I already tested the feature by enabling it and seeing the results. The CI should pass the same way, and if not I will review.