Fix microbenchmarks crash caused by suspended GitHub App#5538
Closed
Fix microbenchmarks crash caused by suspended GitHub App#5538
Conversation
Set MANUAL_BASELINE_BRANCH before bp-runner so the shared template skips github-find-merge-into-branch, which fails with 403 because the GitHub App installation is suspended (incident-51987). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: d94d32a | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
p-datadog
pushed a commit
that referenced
this pull request
Apr 1, 2026
* origin/fix/microbenchmarks-baseline-fallback: Fix microbenchmarks crash by bypassing suspended GitHub App
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets
MANUAL_BASELINE_BRANCHbefore callingbp-runnerin the microbenchmarks job, bypassing thegithub-find-merge-into-branchtool that crashes with a 403 error due to a suspended GitHub App installation (incident-51987).Motivation:
All dd-trace-rb PRs that touch
lib/,ext/,benchmarks/,datadog.gemspec, or.gitlab/are currently failing microbenchmarks. The failure chain:microbenchmarksGitLab job runsbp-runner bp-runner.yml, which uses the sharedrun_microbenchmarkstemplate frombenchmarking-platform-tools.bp-runner.ymlhasparallelize:, the template uses a separate setup script (run-microbenchmarks__setup.sh).github-find-merge-into-branchattempts to authenticate via a GitHub App installation to find the PR's target branch. That App is suspended:bp-runnercatches this asNonZeroExitCodeErrorand fails the job.dd-gitlab/default-pipelinereports failure, andall-jobs-are-greenfails on the GitHub side.The shared template already has an escape hatch: if
MANUAL_BASELINE_BRANCHis set, it skipsgithub-find-merge-into-branchentirely. This PR sets that variable to the repo's default branch (detected from the clone's remote), which ismasterfor dd-trace-rb.Why this approach:
Other tracers already solved this at their own level rather than depending on the shared template:
github-find-merge-into-branchwith|| :in their own customrun-benchmarks.shscriptsbaseline:detectjob usingdd-octo-stsauth with|| echo "main"fallback (in production since March 2025)origin/masteras baselinedd-trace-rb is the only tracer still using the unguarded shared template. This one-line fix matches the resilience pattern every other tracer already has.
Why benchmarking-platform PR #254 didn't fix this:
benchmarking-platform PR #254 was merged as a workaround for incident-51987, but it only patched
steps/post-pr-comment.sh(the PR commenting step). The actual failure is ingithub-find-merge-into-branchduring the setup step — a different code path that uses the same suspended App.Trade-off:
MANUAL_BASELINE_BRANCHis set to the repo's default branch (master), not the PR's actual target branch. For PRs targeting non-default branches, the baseline comparison would be againstmasterinstead of the actual target. This is the same trade-off Go/Cpp/PHP make, and for dd-trace-rb where ~100% of PRs targetmaster, it's correct behavior.Change log entry
None.
Additional Notes:
Verified affected pipelines:
microbenchmarks: [profiling]and[other]both failed with the 403 errorHow to test the change?
Push a PR that touches
lib/orext/(to trigger thechanges:rules for microbenchmarks) and verify the microbenchmarks jobs succeed. Thebp-runnerlog should showMANUAL_BASELINE_BRANCHbeing used instead of callinggithub-find-merge-into-branch.