Add Playwright failure screenshot instructions#38307
Merged
juan-fernandez merged 8 commits intoJul 23, 2026
Merged
Conversation
Contributor
Preview links (active after the
|
xinyeji
approved these changes
Jul 21, 2026
Contributor
Author
|
Updated this PR to document the minimum supported
|
Contributor
Author
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
1 style/consistency nit on the new Playwright reference link, plus a minor note on the reused Cypress screenshot image.
Reviewed d9bd627651b0791daf9eb422c6b7428e8856105e — workflow run
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
juan-fernandez
marked this pull request as ready for review
July 23, 2026 07:44
anmarchenko
approved these changes
Jul 23, 2026
maycmlee
reviewed
Jul 23, 2026
maycmlee
left a comment
maycmlee
left a comment
Contributor
There was a problem hiding this comment.
Just a small suggestion!
Co-authored-by: May Lee <may.lee@datadoghq.com>
Contributor
Author
@maycmlee thanks! I applied it |
maycmlee
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Adds Playwright guidance for uploading test failure screenshots to Test Optimization. Documents the supported
screenshotvalues and clarifies that when Playwright uses'on', Test Optimization uploads only screenshots from failed tests.https://docs-staging.datadoghq.com/juan-fernandez/playwright-failure-screenshots/tests/setup/javascript/?tab=playwright#upload-test-failure-screenshots
Merge readiness
For Datadog employees:
<name>/<description>convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR./reviewto run an automated check that catches common issues before a Documentation team member reviews your PR.AI assistance
AI-assisted drafting, source verification, and validation.
Additional notes
Validation: Vale reported no findings on changed lines,
git diff --checkpassed, and Hugo rendered the updated page locally.