Skip to content

feat: seed root session ID for stable telemetry headers#54

Open
khanayan123 wants to merge 3 commits intomainfrom
ayan.khan/stable-session-id-headers
Open

feat: seed root session ID for stable telemetry headers#54
khanayan123 wants to merge 3 commits intomainfrom
ayan.khan/stable-session-id-headers

Conversation

@khanayan123
Copy link
Copy Markdown

@khanayan123 khanayan123 commented Apr 8, 2026

Summary

Seed root_session_id from the master-generated RuntimeID so all forked workers share the same root session ID for telemetry correlation.

Related

@khanayan123 @claude
feat: seed root session ID from master-generated RuntimeID
7f548bb 
Set root_session_id from the RuntimeID generated in register_hooks
(master process) so all forked worker Tracers share the same root.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 bot commented Apr 8, 2026 •
edited by datadog-prod-us1-4 bot
Loading

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 51.40% (+0.15%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 597043b | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

xlamorlette-datadog
xlamorlette-datadog reviewed Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xlamorlette-datadog xlamorlette-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khanayan123 @claude
fix: remove submodule pin, keep only conf.cpp change
6ab57c4 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123 khanayan123 marked this pull request as ready for review April 13, 2026 15:14
@khanayan123 khanayan123 requested a review from a team as a code owner April 13, 2026 15:14
@khanayan123 khanayan123 requested review from xlamorlette-datadog and removed request for a team April 13, 2026 15:14
@khanayan123 khanayan123 mentioned this pull request Apr 13, 2026
Open
@khanayan123 @claude
chore: update dd-trace-cpp submodule to main (includes #295)
597043b 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@khanayan123
Copy link
Copy Markdown
Author

khanayan123 commented Apr 14, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 14, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-04-14 14:13:02 UTC ℹ️ Start processing command /merge

2026-04-14 14:13:09 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-04-14 14:15:11 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 7m (p90).

2026-04-14 14:22:41 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 9f211e9:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@khanayan123
Copy link
Copy Markdown
Author

khanayan123 commented Apr 14, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 14, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-04-14 14:23:53 UTC ℹ️ Start processing command /merge

2026-04-14 14:24:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 7m (p90).

2026-04-14 14:35:36 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 54a5a8d:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xlamorlette-datadog xlamorlette-datadog xlamorlette-datadog approved these changes

Assignees

No one assigned

Labels

mergequeue-status: rejected

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@khanayan123 @xlamorlette-datadog