Emit telemetry when OpenMetrics reaches its metric limit#24577
Draft
nubtron wants to merge 3 commits into
Draft
Conversation
Contributor
Validation ReportAll 21 validations passed. Show details
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
openmetrics.max_returned_metrics_reachedAgent telemetry counter, emitted once per limiter warning with only the canonicalcheck_namelabel.datadog_checks_baseremains compatible with older Agents, and keep the signal independent fromdebug_metrics.metric_contexts.Validation:
ddev --no-interactive test datadog_checks_base -- tests/base/utils/test_utils.py -k limiterddev --no-interactive test datadog_checks_base -- tests/base/checks/test_agent_check.py -k 'metric_limit or debug_metrics or telemetry'ddev --no-interactive test -fs datadog_checks_baseddev --no-interactive test --lint datadog_checks_base1, and onlycheck_name=openmetricsin the filtered payload.Motivation
OpenMetrics drops metric contexts beyond
max_returned_metricsfor the remainder of a check run. Today this is visible only through a one-per-run warning. Emitting a low-cardinality structured counter at the same transition makes this degradation observable without exposing endpoint or instance identity.Companion Agent bridge and Agent Telemetry profile: DataDog/datadog-agent#53751
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged