feat: add caller owned process/thread context storage#2272
Draft
morrisonlevi wants to merge 2 commits into
Draft
feat: add caller owned process/thread context storage#2272morrisonlevi wants to merge 2 commits into
morrisonlevi wants to merge 2 commits into
Conversation
BenchmarksComparisonCandidateCandidate benchmark detailsBaselineBaseline benchmark details |
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 6234054 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR supports the dd-trace-php PR needed to add Process and Thread contexts. This includes adjusting visibility and storage and a few similar things.
Motivation
PHP needs to support allocating its own storage. It also supports these contexts on macOS and Windows even though it's non-standard (without discovery, just the in-process mechanism). So we needed to change some things.
Additional Notes
I have reviewed the code just a tiny bit. I've been focused on the observable behaviors so far.
How to test the change?
Mostly, this should be tested through PHP: DataDog/dd-trace-php#4062.