Add dora_metrics_read to known OAuth scopes#636
Open
srosenthal-dd wants to merge 1 commit into
Open
Conversation
dora_metrics_write was added to default_scopes() to support pup dora patch-deployment, but the read counterpart was never added. This caused DORA read endpoints (list/get deployments and failures) to 403 with an OAuth token, and made --scopes dora_metrics_read rejected as unknown since all_known_scopes() derives from default_scopes(). Fixes DataDog#635
jack-edmonds-dd
approved these changes
Jul 7, 2026
Member
Author
|
@jack-edmonds-dd looks like I lack permissions to merge in this repo, do you want to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dora_metrics_writeis indefault_scopes()(backingpup dora patch-deployment), butdora_metrics_readwas never added.all_known_scopes()derives fromdefault_scopes(), this madedora_metrics_readget rejected as unknown when requested via--scopes, and meant OAuth tokens never carried it by default, causing DORA read endpoints (list/get deployments and failures) to 403.dora_metrics_read/dora_metrics_writeare both valid, existing permissions, and the API spec gates all four DORA read endpoints (list_dora_deployments,list_dora_failures,get_dora_deployment,get_dora_failure) ondora_metrics_readspecifically.Changes
dora_metrics_readtodefault_scopes()next todora_metrics_write.dora_metrics_readtoread_only_scopes()for--read-onlyparity.Fixes #635
Test plan
cargo checkcargo test(auth module + full suite pass locally)