Draft
Conversation
…file reading and cpu stats calculation functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Describe how to test/QA your changes
Built with serverless-compat-self-monitoring.
To do: Test different collection and aggregation intervals to find optimal balance between collection frequency and added overhead
Added a bunch of debug logs to see what was going on with the calculations:
Looks good but can't read scheduler quota from
cpu.cfs_quota_us, so it always falls back to the host cpu count from the cratenum_cpusReferences: datadog-agent cgroup collection and calculation logic