fix(dogstatsd): handle non-UTF-8 packets gracefully instead of panicking#79
Merged
duncanista merged 2 commits intomainfrom Feb 19, 2026
Conversation
process_packet() used expect() on std::str::from_utf8(), which would panic if a client sent malformed (non-UTF-8) bytes over UDP. This replaces the panic with an error log and early return, dropping the invalid packet safely. Adds a unit test to verify the behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
duncanista
requested review from
Lewis-E and
shreyamalpani
and removed request for
a team
Lewis-E
approved these changes
Feb 19, 2026
shreyamalpani
approved these changes
Feb 19, 2026
duncanista
deleted the
jordan.gonzalez/dogstatsd/fix-utf8-panic-on-malformed-packets
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Process_packet() used expect() on std::str::from_utf8(), which would panic if a client sent malformed (non-UTF-8) bytes over UDP. This replaces the panic with an error log and early return, dropping the invalid packet safely. Adds a unit test to verify the behavior.
Motivation
It would panic before
Describe how to test/QA your changes
Unit tests