test(dogstatsd): add critical unit tests for aggregation, retry logic, and metric filtering#80
Merged
duncanista merged 1 commit intomainfrom Feb 23, 2026
Conversation
…, and metric filtering Add tests covering three previously untested critical paths: - Aggregation semantics: verify count metrics sum, gauge metrics take the last value, distribution sketches merge correctly, and mixed metric types stay in separate contexts. - should_try_next_batch() retry logic: cover all branching paths including 202 success, 4xx permanent errors, 5xx temporary errors, payload errors, destination errors with/without status codes. - aws.lambda.enhanced.invocations filter: verify the hardcoded deduplication filter correctly drops this metric while passing through other metrics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
duncanista
changed the title
duncanista
requested review from
apiarian-datadog and
lym953
and removed request for
a team
lym953
approved these changes
Feb 20, 2026
Contributor
lym953
left a comment
lym953
left a comment
There was a problem hiding this comment.
Thanks for adding the tests!
duncanista
deleted the
jordan.gonzalez/dogstatsd/add-critical-unit-tests
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add tests covering three previously untested critical paths:
Motivation
Ensure we have complete tests
Describe how to test/QA your changes
Unit tests