Skip to content

Comments

[dotnet] Enable and adapt waf telemetry tests for dotnet#6152

Merged
daniel-romano-DD merged 2 commits intomainfrom
dani/dotnetWafTelemetry
Feb 25, 2026
Merged

[dotnet] Enable and adapt waf telemetry tests for dotnet#6152
daniel-romano-DD merged 2 commits intomainfrom
dani/dotnetWafTelemetry

Conversation

@daniel-romano-DD
Copy link
Contributor

@daniel-romano-DD daniel-romano-DD commented Jan 29, 2026

Motivation

Needs V3.37.0 (next release)

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@daniel-romano-DD daniel-romano-DD requested review from a team as code owners January 29, 2026 16:44
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
tests/appsec/waf/test_telemetry.py                                      @DataDog/asm-libraries @DataDog/system-tests-core

@datadog-official
Copy link

datadog-official bot commented Jan 29, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ad2ddf7 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@daniel-romano-DD daniel-romano-DD marked this pull request as draft January 29, 2026 17:28
@daniel-romano-DD daniel-romano-DD added the dotnet Pull requests that update .NET code label Jan 29, 2026
@daniel-romano-DD daniel-romano-DD changed the title [dotnet] Enable and addapt waf telemetry tests for dotnet [dotnet] Enable and adapt waf telemetry tests for dotnet Feb 25, 2026
@daniel-romano-DD daniel-romano-DD marked this pull request as ready for review February 25, 2026 09:43
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e5905e085e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@daniel-romano-DD daniel-romano-DD enabled auto-merge (squash) February 25, 2026 11:46
@daniel-romano-DD daniel-romano-DD enabled auto-merge (squash) February 25, 2026 13:34
@daniel-romano-DD daniel-romano-DD merged commit 0f4217b into main Feb 25, 2026
425 checks passed
@daniel-romano-DD daniel-romano-DD deleted the dani/dotnetWafTelemetry branch February 25, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dotnet Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants