Skip to content

Comments

[PHP] Enable span headers tags on PHP#6330

Merged
estringana merged 4 commits intomainfrom
estringana/enable-span-tags-headers-php
Feb 25, 2026
Merged

[PHP] Enable span headers tags on PHP#6330
estringana merged 4 commits intomainfrom
estringana/enable-span-tags-headers-php

Conversation

@estringana
Copy link
Contributor

Motivation

Enable PHP system tests which ensures content-type and content-length are sent even when appsec does not generate an event

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2026

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
utils/build/docker/php/common/headers.php                               @DataDog/apm-php @DataDog/system-tests-core
utils/build/docker/php/php-fpm/php-fpm.conf                             @DataDog/apm-php @DataDog/system-tests-core

@datadog-official
Copy link

datadog-official bot commented Feb 17, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5a2dc2d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@estringana estringana force-pushed the estringana/enable-span-tags-headers-php branch from 856d687 to 4c8a7c2 Compare February 18, 2026 16:24
@estringana estringana force-pushed the estringana/enable-span-tags-headers-php branch from 279edc8 to c884f76 Compare February 23, 2026 15:14
@estringana estringana marked this pull request as ready for review February 23, 2026 16:39
@estringana estringana requested review from a team as code owners February 23, 2026 16:39
Copy link
Contributor

@cataphract cataphract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless apache is serving the files directly (or there's some more complex configuration going on, like with mod_cache), I don't think this has much to do with Apache: apache should just send whatever php sends it

@estringana
Copy link
Contributor Author

Unless apache is serving the files directly (or there's some more complex configuration going on, like with mod_cache), I don't think this has much to do with Apache: apache should just send whatever php sends it

@cataphract
On fpm those headers were removed. That's why I only enabled them on apache

@estringana estringana force-pushed the estringana/enable-span-tags-headers-php branch from e74d1dc to f47fe4e Compare February 25, 2026 12:36
@estringana estringana requested a review from a team as a code owner February 25, 2026 12:36
@estringana estringana force-pushed the estringana/enable-span-tags-headers-php branch from f47fe4e to d0d5a15 Compare February 25, 2026 12:49
@estringana estringana merged commit d5ed82d into main Feb 25, 2026
577 checks passed
@estringana estringana deleted the estringana/enable-span-tags-headers-php branch February 25, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants