Skip to content

Comments

Component list#6359

Open
nccatoni wants to merge 11 commits intomainfrom
nccatoni/component_list
Open

Component list#6359
nccatoni wants to merge 11 commits intomainfrom
nccatoni/component_list

Conversation

@nccatoni
Copy link
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2026

CODEOWNERS have been resolved as:

utils/const/__init__.py                                                 @DataDog/system-tests-core
utils/const/__main__.py                                                 @DataDog/system-tests-core
utils/const/_const.py                                                   @DataDog/system-tests-core
utils/const/_internal/__init__.py                                       @DataDog/system-tests-core
utils/const/_internal/core.py                                           @DataDog/system-tests-core
utils/const/libraries.yml                                               @DataDog/system-tests-core
utils/const/static/LIBRARIES/all                                        @DataDog/system-tests-core
utils/const/static/LIBRARIES/buildable                                  @DataDog/system-tests-core
.github/actions/get_target_branch/action.yaml                           @DataDog/system-tests-core
conftest.py                                                             @DataDog/system-tests-core
lib-injection/build/build_lib_injection_weblog.sh                       @DataDog/system-tests-core
utils/build/build.sh                                                    @DataDog/system-tests-core
utils/scripts/ci_orchestrators/external_gitlab_pipeline.py              @DataDog/system-tests-core
utils/scripts/compute-workflow-parameters.py                            @DataDog/system-tests-core
utils/scripts/compute_libraries_and_scenarios.py                        @DataDog/system-tests-core
utils/scripts/get-image-list.py                                         @DataDog/system-tests-core
utils/scripts/grep-nightly-logs.py                                      @DataDog/system-tests-core
utils/scripts/ssi_wizards/tools/aws_ssi_registration.py                 @DataDog/system-tests-core

@nccatoni nccatoni force-pushed the nccatoni/component_list branch from 4a97cd6 to 612f225 Compare February 23, 2026 13:33
@nccatoni nccatoni force-pushed the nccatoni/component_list branch from d5f0916 to e70dde8 Compare February 23, 2026 16:22
@nccatoni nccatoni force-pushed the nccatoni/component_list branch from e70dde8 to 1f65d91 Compare February 23, 2026 16:25
@nccatoni nccatoni marked this pull request as ready for review February 23, 2026 16:27
@nccatoni nccatoni requested a review from a team as a code owner February 23, 2026 16:27
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f65d918dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

docker buildx use dd-builder
}

VALID_LIBRARIES=$(python3 -m utils.const LIBRARIES lib_injection)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add fallback when loading library constants in build script

This new VALID_LIBRARIES=$(python3 -m utils.const ...) call runs unconditionally under set -e, so on machines where Python deps are not installed yet (or utils cannot be imported) the script exits before argument parsing, which makes even --help fail; this is a regression from the previous hardcoded list and is inconsistent with utils/build/build.sh, which already added a static-file fallback for the same failure mode.

Useful? React with 👍 / 👎.

@datadog-datadog-prod-us1

This comment has been minimized.

@nccatoni nccatoni force-pushed the nccatoni/component_list branch from a7af73f to 171f76f Compare February 24, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant