Conversation
|
|
4a97cd6 to
612f225
Compare
d5f0916 to
e70dde8
Compare
e70dde8 to
1f65d91
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f65d918dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| docker buildx use dd-builder | ||
| } | ||
|
|
||
| VALID_LIBRARIES=$(python3 -m utils.const LIBRARIES lib_injection) |
There was a problem hiding this comment.
Add fallback when loading library constants in build script
This new VALID_LIBRARIES=$(python3 -m utils.const ...) call runs unconditionally under set -e, so on machines where Python deps are not installed yet (or utils cannot be imported) the script exits before argument parsing, which makes even --help fail; this is a regression from the previous hardcoded list and is inconsistent with utils/build/build.sh, which already added a static-file fallback for the same failure mode.
Useful? React with 👍 / 👎.
This comment has been minimized.
This comment has been minimized.
a7af73f to
171f76f
Compare
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present