Skip to content

Comments

Update to use new preferred envvar to control protocol version#6369

Open
ajgajg1134 wants to merge 2 commits intomainfrom
andrew.glaude/v1Config
Open

Update to use new preferred envvar to control protocol version#6369
ajgajg1134 wants to merge 2 commits intomainfrom
andrew.glaude/v1Config

Conversation

@ajgajg1134
Copy link
Contributor

Motivation

NodeJS already uses this envvar, let's align on the same name instead of introducing a new one.

Changes

DD_TRACE_AGENT_PROTOCOL_VERSION is now the envvar to choose a different protocol version

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

utils/_context/_scenarios/__init__.py                                   @DataDog/system-tests-core

@ajgajg1134 ajgajg1134 marked this pull request as ready for review February 23, 2026 19:08
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner February 23, 2026 19:08
@datadog-official
Copy link

datadog-official bot commented Feb 23, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

❄️ 2 New flaky tests detected

tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM.test_log_method_snapshot[uds-spring-boot] from system_tests_suite (Datadog) (Fix with Cursor)
AssertionError: assert 'Snapshot was not received' is None
 +  where 'Snapshot was not received' = <built-in method join of str object at 0x7f7c84e2aa60>(['Snapshot was not received'])
 +    where <built-in method join of str object at 0x7f7c84e2aa60> = '\n'.join
 +    and   ['Snapshot was not received'] = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f7c76cf0fb0>.setup_failures

self = <tests.debugger.test_debugger_probe_snapshot.Test_Debugger_Method_Probe_Snaphots_With_SCM object at 0x7f7c76cf0fb0>

    def test_log_method_snapshot(self):
>       self._assert()

...
tests.test_ipv6.Test_Basic.test_main[apache-mod-8.0-zts] from system_tests_suite (Datadog) (Fix with Cursor)
ValueError: No trace has been found for request VZFUMZOGUTZOBQKRLXZEIQMVSUIBILAFOAMW

self = <tests.test_ipv6.Test_Basic object at 0x7f9ff0f4d6a0>

    def test_main(self):
>       interfaces.agent.assert_trace_exists(self.r)

tests/test_ipv6.py:11: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

...

ℹ️ Info

🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 90e361b | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants