python: properly propagate shutdown signal in weblogs#6374
Draft
florentinl wants to merge 1 commit intomainfrom
Draft
python: properly propagate shutdown signal in weblogs#6374florentinl wants to merge 1 commit intomainfrom
florentinl wants to merge 1 commit intomainfrom
Conversation
Contributor
|
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: a5517db | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
edc43ef to
e599acc
Compare
4b1e3f2 to
aec0b37
Compare
aec0b37 to
a5517db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Re-enable this test:
tests/test_resource_renaming.py::Test_Resource_Renaming_Stats_Aggregation_Keys::test_stats_aggregation_with_method_and_endpoint.The main problem is that the weblog never receive the SIGTERM signal from Docker and get killed right away without having the possibility to flush their buffers on shutdown.
This PR ensures that the SIGTERM signal properly propagates to the python interpreters running the app and and can be caught by
dd-trace-py.Changes
execto replace the shell process with the actualddtrace-runcommand.Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present