fix: stop RC tests on last expected request without requiring a trailing poll#6776
Merged
fix: stop RC tests on last expected request without requiring a trailing poll#6776
Conversation
…iling poll The validate() functions in RC sequence tests used to return True only when called with a request AFTER all expected ones had been validated, requiring an extra trailing RC poll. This made them fragile when the tracer stops polling shortly after the last mocked response. Fix: return True directly after validating and incrementing on the last expected request, removing the need for any additional poll.
Contributor
|
|
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 84c0836 | Docs | Datadog PR Page | Give us feedback! |
cbeauchesne
approved these changes
Apr 21, 2026
mellon85
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The validate() functions in RC sequence tests used to return True only when called with a request AFTER all expected ones had been validated, requiring an extra trailing RC poll. This made them fragile when the tracer stops polling shortly after the last mocked response.
This can happen in tracers that support the
/flushmechanism and so the setup phase exits before an additional RC poll request happening. Related to #6772Changes
Fix: return True directly after validating and incrementing on the last expected request, removing the need for any additional poll.
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present