Skip to content

chore: dump Library metadata from /binaries/metadata.txt if available#6802

Open
brettlangdon wants to merge 6 commits intomainfrom
brettlangdon/dd-trace-py.s3.metadata
Open

chore: dump Library metadata from /binaries/metadata.txt if available#6802
brettlangdon wants to merge 6 commits intomainfrom
brettlangdon/dd-trace-py.s3.metadata

Conversation

@brettlangdon
Copy link
Copy Markdown
Member

@brettlangdon brettlangdon commented Apr 23, 2026

Motivation

When running CI against a GIT_REF like main for dd-trace-py it can be hard to know exactly which artifact was used for the tests.

This change will look for a possible /metadata.txt file if it exists in S3 and supports dumping the metadata both in install_ddtrace.sh, and when dumping container metadata when running tests.

Example PR/test run where it is difficult to understand the artifact:

https://github.com/DataDog/system-tests/actions/runs/24707739878/job/72305061453?pr=6721#step:34:22

This change will add dumping:

Library metadata:
commit_sha=dc5f4286e2de5be4c8ee74bba6523649b2690f74
commit_short_sha=dc5f4286
ref_name=brettlangdon/s3.metadata
pipeline_id=109300625
package_version=4.8.0rc5
created_at=2026-04-23T13:58:51Z

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

CODEOWNERS have been resolved as:

utils/_context/containers.py                                            @DataDog/system-tests-core
utils/build/docker/python/install_ddtrace.sh                            @DataDog/apm-python @DataDog/asm-python @DataDog/system-tests-core

@brettlangdon brettlangdon force-pushed the brettlangdon/dd-trace-py.s3.metadata branch from ace7241 to eb23336 Compare April 23, 2026 13:47
@brettlangdon brettlangdon added the python Pull requests that update Python code label Apr 23, 2026
@brettlangdon brettlangdon changed the title [dd-trace-py]: dump s3 artifact metadata if it is available chore: Dump Library metadata from /binaries/metadata.txt if available Apr 23, 2026
@brettlangdon brettlangdon changed the title chore: Dump Library metadata from /binaries/metadata.txt if available chore: dump Library metadata from /binaries/metadata.txt if available Apr 23, 2026
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Apr 23, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8ba3d84 | Docs | Datadog PR Page | Give us feedback!

@brettlangdon brettlangdon marked this pull request as ready for review April 23, 2026 15:34
@brettlangdon brettlangdon requested review from a team as code owners April 23, 2026 15:34
@brettlangdon brettlangdon requested review from KowalskiThomas and florentinl and removed request for a team April 23, 2026 15:34
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 812284eacc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread utils/build/docker/python/install_ddtrace.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergequeue-status: removed python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants