Skip to content

[debugger] add minimum debugger snapshot metadata checks#6807

Draft
watson wants to merge 2 commits intomainfrom
watson/debugger-payload-basic-tests
Draft

[debugger] add minimum debugger snapshot metadata checks#6807
watson wants to merge 2 commits intomainfrom
watson/debugger-payload-basic-tests

Conversation

@watson
Copy link
Copy Markdown
Contributor

@watson watson commented Apr 24, 2026

Motivation

Add system-tests coverage for the minimum debugger snapshot metadata we expect on probe-result payloads, while separating body-field checks from ddtags checks so tracer-specific gaps are easier to diagnose and gate independently.

Changes

  • add debugger snapshot assertions for root payload properties:
    • service
    • ddsource
  • add a separate debugger snapshot test for basic DD tags:
    • host:test
    • debugger_version
    • env
    • version
  • validate ddtags across both possible sources:
    • URL query params
    • JSON payload body
  • validate that debugger ddtags do not contain duplicate keys across the combined query/body view
  • normalize the expected debugger version value for:
    • Java build metadata (+ -> ~)
    • Python release candidate formatting (-rc -> rc)
  • gate the remaining unsupported basic_ddtags behavior for:
    • Go
    • Java
    • .NET
    • Ruby

Current failing behaviors

test_payload_basic_ddtags_snapshot

  • Go:
    • payload only includes the agent-side baseline tags
    • missing debugger_version, env, and version
  • Java:
    • payload duplicates agent_version, env, and version ddtag keys
  • .NET:
    • payload duplicates the host ddtag key (host:test and host:weblog)
    • payload is also missing debugger_version
  • Ruby:
    • payload duplicates the host ddtag key (host:test and host:weblog)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
manifests/golang.yml                                                    @DataDog/dd-trace-go-guild
manifests/java.yml                                                      @DataDog/asm-java @DataDog/apm-java
manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby
tests/debugger/test_debugger_probe_snapshot.py                          @DataDog/debugger @DataDog/system-tests-core

@datadog-official
Copy link
Copy Markdown

datadog-official Bot commented Apr 24, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5e20103 | Docs | Datadog PR Page | Give us feedback!

Split debugger snapshot metadata validation into root-property and basic
ddtags tests so we can catch payload regressions without conflating
tracer differences. Gate the remaining unsupported tracer behaviors
explicitly, including duplicate or missing basic DD tags.
@watson watson force-pushed the watson/debugger-payload-basic-tests branch from 5d0af97 to c4aff4b Compare April 25, 2026 05:30
Copy link
Copy Markdown
Contributor Author

watson commented Apr 25, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson force-pushed the watson/debugger-payload-basic-tests branch from 15f4ea1 to 5e20103 Compare April 25, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant