[java] Fix test_log_generation_enabled for vertx3/vertx4 after AIDM-583 fix#6996
Merged
Conversation
…/vertx4; fix vertx3 build The test was previously passing for vertx3/vertx4 only because a bug in NettyMultipartHelper caused UnsupportedOperationException from Vert.x's NettyFileUpload.getHttpDataType() to bubble up to ByteBuddy's suppress handler, which logged it via ExceptionLogger with a Throwable attached — the DDTelemetryLogger then collected it as a telemetry log payload. After fixing that bug in dd-trace-java#11268, vertx3/vertx4 no longer produce agent telemetry logs in the DEFAULT scenario, matching the behavior of play, akka-http, etc. Also add slf4j-api + slf4j-jdk14 to vertx3/pom.xml to fix a compilation error introduced in #6882 where Api10RouteProvider.java was added with an SLF4J import but without the required dependency.
Contributor
|
|
…s slf4j-api transitively
…d-trace-java#11268 The UnsupportedOperationException from NettyFileUpload.getHttpDataType() no longer propagates to the advice exception handler after the fix in dd-trace-java#11268.
jandro996
changed the title
🎉 All green!🧪 All tests passed 🔗 Commit SHA: c872f2a | Docs | Datadog PR Page | Give us feedback! |
The fix for AIDM-583 lives in dd-trace-java#11268 (not yet merged). System-tests CI runs with the production agent, where the error still occurs. Keep the allowed_patterns entry until the tracer fix reaches prod.
jandro996
requested review from
daniel-romano-DD,
manuel-alvarez-alvarez and
mcculls
mcculls
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
test_log_generation_enabled[vertx3]fails in dd-trace-java CI for PR #11268, which fixes AIDM-583.The full chain
AIDM-583 is a bug where
NettyMultipartHelper.collectBodyData()callsNettyFileUpload.getHttpDataType(), which throwsUnsupportedOperationExceptionbecause Vert.x'sNettyFileUploaddoesn't implement that method. When AppSec tests in the DEFAULT scenario send multipart requests to the vertx3/wafendpoint, Netty'sHttpPostMultipartRequestDecoderencounters these objects, and the exception escapes to ByteBuddy'ssuppress = Throwable.classhandler, which logs:DDTelemetryLoggercollects any agent log that carries aThrowable, so this debug-level log becomes a telemetrylogspayload. This was:test_java_telemetry_logstest_log_generation_enabledpassAfter DataDog/dd-trace-java#11268 adds
catch (UnsupportedOperationException ignored)incollectBodyData(), the exception is silenced before reaching the advice handler. No more telemetry logs from this path.What this PR does
manifests/java.yml: marktest_log_generation_enabledasmissing_featurefor vertx3 and vertx4, matching the behavior ofplay,akka-http,jersey-grizzly2, etc.tests/test_library_logs.py: keeps the AIDM-583 workaround with a note — it will be removed once Add server.request.body.filenames AppSec address for Vert.x 3.4, 4.0 and 5.0 dd-trace-java#11268 is merged to prod.Testing
Verified locally by building the vertx3 weblog with the dd-trace-java#11268 agent jar and running:
Result:
1 xfailed(test correctly skipped as missing_feature for vertx3).