Add coverage for DBM dynamic_service mode#6997
Open
amarziali wants to merge 4 commits into
Open
Conversation
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: f213d25 | Docs | Datadog PR Page | Give us feedback! |
xlamorlette-datadog
approved these changes
May 21, 2026
raphaelgavache
approved these changes
May 21, 2026
cbeauchesne
requested changes
May 21, 2026
f257776 to
68153e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add coverage for the new DD_DBM_PROPAGATION_MODE=dynamic_service value that combines service mode behaviour with automatic SQL base hash injection, without requiring users to separately set DD_DBM_INJECT_SQL_BASEHASH=true.
Setting dynamic_service is equivalent to:
DD_DBM_PROPAGATION_MODE=service
DD_DBM_INJECT_SQL_BASEHASH=true
The test checks that the basehash is the same in both the
ddshcomment field and the related span meta_dd. propagated_hashNote: already tested working locally with the in progress java implementation: DataDog/dd-trace-java#11432
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present