Improvement/web api framework optimization#17
Open
NielsdeBoerDAE wants to merge 12 commits intoproduction/betafrom
Open
Improvement/web api framework optimization#17NielsdeBoerDAE wants to merge 12 commits intoproduction/betafrom
NielsdeBoerDAE wants to merge 12 commits intoproduction/betafrom
Conversation
Previously certain attributes were fetched from the database for every single record. Now these properties are defined on object initialization and only the property is retrieved for each find. Should give a pretty good performance increase.
Applications that support sql filters can now use them to optimize constraints a little.
Allow developers to determine what index they want to use for finds on a child table.
It is now possible to pass query parameters twice. This allows you to apply two types of constraints to the same column
No longer create and destroy handles during a for loop. The handle will be created once and then be reused with InitializeJsonObject again. This should help improve performance
Implemented pagination for the cRestDataset. It is now possible to pass a offset in the query parameters. Since data dictionaries don't actually support an offset it still has to find the rows, it just skips over the first few depending on the offset.
| // This determines how many records we return during a get all | ||
| Property Integer piLimitResults 0 | ||
| // This determines how many records to skip during a GET request. | ||
| Property Integer piOffset 0 |
Owner
There was a problem hiding this comment.
This should be runtime specific and not in a design-time object-class.
|
|
||
| // Grabs the old psSQLFilter and restores it | ||
| { Visibility=Private } | ||
| Property String psOldSQLfilter "" |
Owner
There was a problem hiding this comment.
This should be runtime specific and not in a design-time object-class.
| @@ -77,15 +78,25 @@ Class cOpenApiSpecification is a cObject | |||
| If (sApiRoot = "") Begin | |||
| Get ServerVariable of ghoWebServiceDispatcher "SERVER_NAME" to sServerName | |||
| Get ServerVariable of ghoWebServiceDispatcher "URL" to sApiRoot | |||
Owner
There was a problem hiding this comment.
In the future see if we can check a forwarded for server name and url as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request features the following improvements:
Closes #15