Refactor: Broke up eGraphGP, added optional rng seed to RegressionConfig, added nix flake for simple dev setup#2
Open
ashwinmathi wants to merge 23 commits into
Open
Conversation
Replace fragile pattern matching in toNonTerminal with UnaryFunc/BinaryFunc GADTs that pair operation names with implementations.
mchav
requested changes
Feb 11, 2026
| import qualified DataFrame.Functions as F | ||
| import Symbolic.Regression | ||
|
|
||
| example_predictMPG :: IO () |
Member
There was a problem hiding this comment.
This example is effectively unrunnable right? First cause the data file it relies on isn't in source control and it's not an executable.
Author
There was a problem hiding this comment.
Removed this file and transferred the example modifications to the README. iirc this was just defining mpg and avoiding the hardcoded keys for levels
| , binaryFunctions :: [D.Expr Double -> D.Expr Double -> D.Expr Double] | ||
| , binaryFunctions :: [BinaryFunc] | ||
| {- ^ Binary operations to include in the search space | ||
| (default: @[(+), (-), (*), (\/)]@) |
Member
There was a problem hiding this comment.
Let's update the haddock below as well with the new API.
| import: warnings | ||
| default-language: Haskell2010 | ||
| type: exitcode-stdio-1.0 | ||
| hs-source-dirs: test |
Member
There was a problem hiding this comment.
Let's add one or two hunit tests.
Author
There was a problem hiding this comment.
added tests for datasets known to have constant, linear, quadratic, multivariate models with customized configs
…s for UnaryFunc and BinaryFunc, use convenience functions for UnaryFunc and BinaryFunc
…'Example' module from library stanza's exposed modules
… and multi-variable models
mchav
requested changes
Feb 12, 2026
…defined seed for deterministic rng
…en target and predicted expression
…op, and report generation Reduces egraphGP from ~420 lines to ~230 lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.