Unified run.py file allowing execution of an excavator against a file.#3
Closed
alexjeffburke wants to merge 3 commits intoDatamuseum-DK:mainfrom
Closed
Unified run.py file allowing execution of an excavator against a file.#3alexjeffburke wants to merge 3 commits intoDatamuseum-DK:mainfrom
alexjeffburke wants to merge 3 commits intoDatamuseum-DK:mainfrom
Conversation
Support a directory argument of "." to allow outputting in the current directory with an automatic suffix: ./_autoarchaologist
Make the minimal set of changes such that we are able to trigger the excavation to a known directory of the in-tree example file. Check that the expected HTML files were written for this known excavation and assert some basic properties of the excavated arifacts. The commit includes reworking of run_example wherein its excavation is declared as a class and its core logic separated out into a run file. This is done both to allow the tests to easily make use of the logic and as groundwork for subsequent work to provide a unified entry point.
Provide a central excavators module which re-exports the various named configurations. Use this to implement a CLI recognizing a --excavator argument which will call an exacavtion of the supplied filename. Rework run_example as a wrapper around this new unified CLI. Expand the README documenting both run_example and unified run entry points noting that in the absence of arguments a list of supported excavators is output. While here add smoke tests for basic validation of exports and scripts.
alexjeffburke
force-pushed
the
unified-cli
branch
from
da41068 to
04a75b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a central excavators module which re-exports the various named configurations. Use this to implement a CLI recognizing a --excavator argument which will call an exacavtion of the supplied filename.
Rework run_example as a wrapper around this new unified CLI. Expand the README documenting both run_example and unified run entry points noting that in the absence of arguments a list of supported excavators is output.
While here add smoke tests for basic validation of exports and scripts.