Post-merge polish: row upvote, tappable usernames, URL-above-title, reader links, feed header collapse#18
Open
gingerbeardman wants to merge 6 commits into
Conversation
Story rows now show the points as a tappable upvote when signed in, with an optimistic count bump persisted via VoteStore and a web-view fallback if the native vote is rejected. HN renders no vote arrow on your own posts, so the affordance is hidden there (in feed rows and in the discussion header/comments) rather than failing into the web view.
Story rows take an optional onSelectUser closure: feed, saved, and search pass one that pushes the author's profile, so tapping the username opens it while the rest of the row still opens the story. The meta row drops the bullet separator so author and time read like the other meta items, and the host becomes a shortcut to the article.
New opt-in setting that places the source host above the headline (classic HN layout) instead of beneath it, shrinking the rank to match and sharing the first line. Surfaced in Settings and on the onboarding "Tuned for you" step, where the live preview reflects it too.
Inline comment/text links now open in Safari Reader when the Reader Mode setting is on, matching how story articles already open. Renames the setting to "Open Links in Reader Mode" to reflect that it covers every in-app link, not only those Reader happens to support.
The Ember wordmark fades and lifts while the feed picker eases up at half rate; once the wordmark is gone the nav bar collapses to reclaim its space, deriving the real bar height from the scroll-view inset so the list doesn't jump on first use. A wide hide/show gap prevents the toggle from flapping at the threshold.
gingerbeardman
force-pushed
the
feature/post-merge-polish
branch
from
June 23, 2026 12:05
3b5c4d6 to
6647d27
Compare
Owner
|
Automated triage notes (maintainer will do the formal review):
|
Owner
|
Lets see what we do about the logo. It really looks tinderish. |
Contributor
Author
|
I'll have a think on the logo. I'm using my fork of this daily and is yet to let me down. I've added several more features in my fork (comment skip, refresh stale, more UI tweaks) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up tidy-up after the account-support merge (#13). Six self-contained commits: