Conform files to Arduino IDE library standards#2
Open
cevich wants to merge 1 commit intoDavidAndrews:masterfrom
cevich:Arduino_LCD_Menu
Open
Conform files to Arduino IDE library standards#2cevich wants to merge 1 commit intoDavidAndrews:masterfrom cevich:Arduino_LCD_Menu
cevich wants to merge 1 commit intoDavidAndrews:masterfrom
cevich:Arduino_LCD_Menu
Conversation
* Moved Arduino_LCD_Menu.ino into examples sub-directory * Added master Arduino_LCD_Menu.h/Arduino_LCD_Menu.cpp files so users only have to #include <Arduino_LCD_Menu.h> * Fixedup ifndef's header-file protections * Renamed readme to README so it stands out in dir listing * Added separate LICENSE file * Line-wrapped license comment text at 80-col. * Line-wrapped README text at 80-col. Signed-off-by: Chris Evich <chris-arduino@anonomail.me>
|
Hello! I tried to use custom characters in menu labels to make cyrillic letters, and program does not work properly. Can you modify library to use custom character on LCD? g_menuLCD.getLCD()->createChar(1, D_cyr); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, mostly just a bunch of cosmetic changes to make this work more smoothly in the Arduino IDE. With these changes, the library shows up in the IDE menu's, including the example code. I haven't actually tested any of these changes yet, because I wanted to know what you think. Please comment, and I'll update this pull request as needed. Thanks!