fix: resolve 15 code review findings (5 critical, 10 warnings)

[W00DSRULES]

Summary

Deep code review (/gsd-code-review --depth=deep) across 22 source files surfaced 19 findings. This PR resolves all 5 critical blockers and all 10 warnings. 123 tests pass.

Critical Fixes (5)

• CR-01 — Added "memory_guidance" to Blackboard.allowed_types; was raising ValueError silently on every run, agents never received memory context
• CR-02 — Fixed shared-state race: promoted blackboard from self.blackboard to a local variable in _execute_inner, eliminating cross-session data contamination under concurrent requests
• CR-03 — DELETE /tasks/{task_id} now cancels the in-flight asyncio.Task; previously the background coroutine continued writing to a deleted dict key causing KeyError
• CR-04 — RedisSessionStore migrated from synchronous redis to redis.asyncio; was blocking the event loop on every Redis round-trip
• CR-05 — Removed duplicate timeout=120 kwarg from OpenAI client call; asyncio.wait_for already handles the timeout, double-wrapping caused connection leaks and misattributed errors

Warning Fixes (10)

• WR-01 — _add_entry now logs a warning on exception instead of silently swallowing errors
• WR-02 — Removed dead try/except where both branches performed the same operation
• WR-03 — embedding_cache.py now reads EMBEDDING_CACHE_DIR via get_settings() instead of os.environ directly; added reset_embedding_cache() to test fixture
• WR-04 — Replaced redis.keys() (O(N) blocking scan) with redis.scan_iter() in Blackboard
• WR-05 — _estimate_cost now includes input token cost; was systematically under-reporting spend and could allow budget overruns
• WR-06 — Removed dead if route.activate_synthesizer: guard inside if budget_tight: branch
• WR-07 — _tasks dict capped at 1000 entries with LRU eviction via OrderedDict; was growing unbounded
• WR-08 — Replaced deprecated datetime.utcnow() with datetime.now(timezone.utc) across 5 locations
• WR-09 — Removed dead _is_sentence_terminator function in tools/mcp/rag.py
• WR-10 — Replaced print(..., file=sys.stderr) with structured logger.error(..., exc_info=True) in corpus ingest

Verification

• 123 tests pass (pytest tests/ -x -q)
• All Critical and Warning findings addressed
• 4 Info findings (IN-01 to IN-04) left for a follow-up

Files Changed

apps/api/main.py · core/blackboard/engine.py · core/corpus/ingest.py · core/embedding_cache.py · core/orchestrator/thesis_flow.py · core/router/engine.py · core/sessions/store.py · providers/adapters.py · providers/unified.py · tests/conftest.py · tools/mcp/rag.py

🤖 Generated with Claude Code