Skip to content

Test against jQuery 4 #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tagliala merged 1 commit into from
Jan 27, 2026
Merged

Test against jQuery 4 #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## main / unreleased

* [ENHANCEMENT] Test against jQuery 4.0.0

## 23.0.0 / 2026-01-07

* [FEATURE] Breaking change: Add `csv` prefix to CSV related data attributes:
Expand Down
2 changes: 1 addition & 1 deletion lib/client_side_validations/action_view/form_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def check_box(method, options = {}, checked_value = '1', unchecked_value = '0')
end
end

if ::ActionView::Helpers::FormBuilder.public_instance_methods.include?(:collection_checkboxes)
if ::ActionView::Helpers::FormBuilder.public_method_defined?(:collection_checkboxes)
alias collection_checkboxes collection_check_boxes
end

Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,20 @@
"test": "test/javascript/run-qunit.mjs"
},
"devDependencies": {
"@babel/core": "^7.28.5",
"@babel/preset-env": "^7.28.5",
"@babel/core": "^7.28.6",
"@babel/preset-env": "^7.28.6",
"@rollup/plugin-babel": "^6.1.0",
"@rollup/plugin-node-resolve": "^16.0.3",
"chrome-launcher": "^1.2.1",
"eslint": "^9.39.2",
"eslint-plugin-compat": "^6.0.2",
"eslint-plugin-compat": "^6.1.0",
"neostandard": "^0.12.2",
"puppeteer-core": "^24.34.0",
"rollup": "^4.55.1",
"puppeteer-core": "^24.36.0",
"rollup": "^4.57.0",
"rollup-plugin-copy": "^3.5.0"
},
"peerDependencies": {
"jquery": "^3.7.1"
"jquery": "^3.7.1 || ^4.0.0"
},
"main": "dist/client-side-validations.js",
"module": "dist/client-side-validations.esm.js",
Expand Down
2 changes: 1 addition & 1 deletion test/action_view/cases/test_form_for_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def test_collection_check_boxes
assert_dom_equal expected, output_buffer
end

if ::ActionView::Helpers::FormBuilder.public_instance_methods.include?(:collection_checkboxes)
if ::ActionView::Helpers::FormBuilder.public_method_defined?(:collection_checkboxes)
def test_collection_checkboxes
form_for(@post, validate: true) do |f|
concat f.collection_checkboxes(:cost, [], :id, :name)
Expand Down
2 changes: 1 addition & 1 deletion test/action_view/cases/test_form_with_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ def test_form_with_collection_check_boxes
assert_dom_equal expected, output_buffer
end

if ::ActionView::Helpers::FormBuilder.public_instance_methods.include?(:collection_checkboxes)
if ::ActionView::Helpers::FormBuilder.public_method_defined?(:collection_checkboxes)
def test_form_with_collection_checkboxes
form_with(model: @post, validate: true) do |f|
concat f.collection_checkboxes(:cost, [], :id, :name)
Expand Down
2 changes: 1 addition & 1 deletion test/javascript/server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def call(env)
use AssetPath, urls: ['/vendor/assets/javascripts'], root: File.expand_path('../..', settings.root)
use AssetPath, urls: ['/vendor/assets/javascripts'], root: File.expand_path('../', $LOAD_PATH.find { |p| p.include?('jquery-rails') })

DEFAULT_JQUERY_VERSION = '3.7.1'
DEFAULT_JQUERY_VERSION = '4.0.0'
QUNIT_VERSION = '2.25.0'

helpers do
Expand Down