chore: add additional field#99
Merged
Merged
Conversation
Contributor
| | source = ${source} | ||
| | date = ${dateTemplate} | ||
| | source = ${source} | ||
| | other_fields = {{information field|Academic context|{{en|1=Geospatial street-level imagery from external site}}}} |
Contributor
There was a problem hiding this comment.
Missing test coverage for the new
other_fields line
The buildWikitext describe block has thorough tests for license, heading, pano, and coordinates, but none assert that other_fields is present in the output. If the template line is accidentally dropped or mis-formatted in a future edit, no test will catch it — the existing assertions all use .toContain() on unrelated substrings and will keep passing regardless.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://commons.wikimedia.org/w/index.php?title=User_talk:F%C3%A6&diff=prev&oldid=1235015968