Import Many2many with ID instead of name#50
Open
levkar wants to merge 1 commit intoDeBortoliWines:masterfrom
Open
Import Many2many with ID instead of name#50levkar wants to merge 1 commit intoDeBortoliWines:masterfrom
levkar wants to merge 1 commit intoDeBortoliWines:masterfrom
Conversation
Collaborator
|
Hi, |
Author
|
You can use existing tests since this fix doesn't add anything new. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, many2many records are imported by their names. It is reading names of all ids and trying to import records by matching name field. Records with different id's with the same name is a huge problem.
This PR changes many2many importing directly with ID instead of name. It improves many2many import performance and eliminate matching errors.