feature: cumulative worker id without entry server#255
Open
YuriCat wants to merge 5 commits intoDeNA:developfrom
Open
feature: cumulative worker id without entry server#255YuriCat wants to merge 5 commits intoDeNA:developfrom
YuriCat wants to merge 5 commits intoDeNA:developfrom
Conversation
Member
ikki407
reviewed
Jan 26, 2022
Comment on lines
+172
to
+174
| if gather_id == 0: # call once at every machine | ||
| print(args) | ||
| prepare_env(args['env']) |
Member
There was a problem hiding this comment.
Is this safe...? I can't think of any problems though...
Contributor
Author
There was a problem hiding this comment.
I'd like to remove prepare_env() ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combining #245 and #246, it seems natural to implement it like this.