Skip to content

fix: enforce secure session cookies in production#134

Merged
DeadIndian merged 1 commit into
DeadIndian:mainfrom
KGFCH2:fix/server-session-cookie-security
Jun 3, 2026
Merged

fix: enforce secure session cookies in production#134
DeadIndian merged 1 commit into
DeadIndian:mainfrom
KGFCH2:fix/server-session-cookie-security

Conversation

@KGFCH2
Copy link
Copy Markdown
Contributor

@KGFCH2 KGFCH2 commented Jun 2, 2026

Related Issue

Closes #133

Summary

Hardens backend session cookies by enabling secure cookies and proxy settings in production.

Changes Made

  • Added production detection in server/index.js
  • Updated express-session settings:
    • proxy: true in production
    • cookie.secure: true in production
    • cookie.sameSite: lax

Testing

  • Verified server starts with the new session config
  • Confirmed local development still works
  • Confirmed production-sensitive settings are gated by NODE_ENV === "production"

Impact

Improves session security for deployed backend instances.

Checklist

  • Code follows project standards
  • Tested locally
  • No unrelated changes included
  • Production cookie security enforced

@DeadIndian DeadIndian added good first issue Good for newcomers newbie Level 1 issue for ELUSOC 2026 ELUSOC labels Jun 3, 2026
@DeadIndian DeadIndian merged commit 1d499ea into DeadIndian:main Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ELUSOC good first issue Good for newcomers newbie Level 1 issue for ELUSOC 2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Server session cookies are insecure in production

2 participants