Skip to content

accessibility: add dialog semantics and labels to task modal dialogs #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeadIndian merged 1 commit into from
Jun 3, 2026
+16 −4
Merged

accessibility: add dialog semantics and labels to task modal dialogs #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions client/src/pages/app/TasksPage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,18 @@ const CreateTaskModal = ({ events, onClose, onCreated }) => {
onClick={(e) => e.target === e.currentTarget && onClose()}>
<motion.div
className="modal"
role="dialog"
aria-modal="true"
aria-labelledby="create-task-title"
style={{ maxWidth: 560 }}
initial={{ opacity: 0, scale: 0.95 }}
animate={{ opacity: 1, scale: 1 }}>
<div className="modal-header">
<h2 className="modal-title">Create Task</h2>
<button className="btn btn-ghost btn-sm" onClick={onClose}>
<h2 id="create-task-title" className="modal-title">Create Task</h2>
<button
className="btn btn-ghost btn-sm"
onClick={onClose}
aria-label="Close create task dialog">
<RiCloseLine />
</button>
</div>
Expand Down Expand Up @@ -310,11 +316,14 @@ const SubmitTaskModal = ({ task, onClose, onSubmitted }) => {
onClick={(e) => e.target === e.currentTarget && onClose()}>
<motion.div
className="modal"
role="dialog"
aria-modal="true"
aria-labelledby="submit-task-title"
initial={{ opacity: 0, scale: 0.95 }}
animate={{ opacity: 1, scale: 1 }}>
<div className="modal-header">
<div>
<h2 className="modal-title">Submit Task</h2>
<h2 id="submit-task-title" className="modal-title">Submit Task</h2>
<p
style={{
fontSize: "0.82rem",
Expand All @@ -324,7 +333,10 @@ const SubmitTaskModal = ({ task, onClose, onSubmitted }) => {
{task.title}
</p>
</div>
<button className="btn btn-ghost btn-sm" onClick={onClose}>
<button
className="btn btn-ghost btn-sm"
onClick={onClose}
aria-label="Close submit task dialog">
<RiCloseLine />
</button>
</div>
Expand Down